openstack/python-monascaclient
Code Issues Proposed changes

Update hacking version

Browse Source 
1. Use latest release 1.1.0 and compatible changes w.r.t pep8
2. cleanup of .keys() from dict_object.keys() *in* operator

Story: 2004930
Task: 29772
Change-Id: I5c41100494efee5f0d29d094ccb4d85a6f64bcec
This commit is contained in:
ZhijunWei 2018-12-28 23:04:03 +08:00 committed by Witold Bedyk
parent 4339da2ee5
commit 7939777a15
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
HACKING.rst
View File

@ -1,4 +1,4 @@
python-monascaclient Style Commandments python-monascaclient Style Commandments
=============================================== =======================================
Read the OpenStack Style Commandments http://docs.openstack.org/hacking/latest Read the OpenStack Style Commandments http://docs.openstack.org/hacking/latest

2
lower-constraints.txt
View File

@ -19,7 +19,7 @@ flake8==2.5.5
future==0.16.0 future==0.16.0
gitdb==0.6.4 gitdb==0.6.4
GitPython==1.0.1 GitPython==1.0.1
hacking==0.12.0 hacking==1.1.0
imagesize==0.7.1 imagesize==0.7.1
iso8601==0.1.11 iso8601==0.1.11
Jinja2==2.10 Jinja2==2.10

2
monascaclient/common/utils.py
View File

@ -78,7 +78,7 @@ def print_dict(d, formatters=None):
caching=False, print_empty=False) caching=False, print_empty=False)
pt.align = 'l' pt.align = 'l'
for field in d.keys(): for field in d:
if field in formatters: if field in formatters:
pt.add_row([field, formatters[field](d[field])]) pt.add_row([field, formatters[field](d[field])])
else: else:

4
monascaclient/v2_0/__init__.py
View File

@ -13,6 +13,6 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
__all__ = ['Client']
from monascaclient.v2_0.client import Client from monascaclient.v2_0.client import Client
__all__ = ['Client']

2
test-requirements.txt
View File

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0 hacking>=1.1.0,<1.2.0 # Apache-2.0
bandit>=1.1.0 # Apache-2.0 bandit>=1.1.0 # Apache-2.0
coverage!=4.4,>=4.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0