94c5223f02
osc-lib library is foundation on which a CLI client for openstack can be built. It is meant to facilitate several aspects, that were previously hard-coded in client: * keystone communication handling * supporting multiple authentication methods (not only password) * common authentication parameters (i.e. environmental OS_*) * communicating over http with service endpoint * interactive CLI mode Thanks to those items, it was possible not only to drop nearly 3k lines of code and replace them with osc-lib but also increase reliabity of the client in terms of new openstack releases. Also it allowed to greatly simpify existing set of unit-tests. They are now testing only actual logic instead of mocking entire process of calling shell (i.e. MonascaShell.run(args)) or mocking HTTP communication. Both items are handled by osc-lib thus not they are not subject of monascaclient unit tests layers. Note: This change is partial integration with osc-lib and its main purpose is to move the responsibility of: * keystone communication * rest-ful communication with service endpoint to underlying library thus allowing client to implement only necessary functionality and not supporting boilerplate code, mentioned above. Story: 2000995 Task: 4172 Change-Id: I1712a24739438e2d8331a495f18f357749a633c5
41 lines
1.4 KiB
Python
41 lines
1.4 KiB
Python
# (C) Copyright 2014-2015 Hewlett Packard Enterprise Development Company LP
|
|
# Copyright 2017 FUJITSU LIMITED
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from osc_lib.api import api
|
|
|
|
from monascaclient.v2_0 import alarm_definitions as ad
|
|
from monascaclient.v2_0 import alarms
|
|
from monascaclient.v2_0 import metrics
|
|
from monascaclient.v2_0 import notifications
|
|
from monascaclient.v2_0 import notificationtypes as nt
|
|
|
|
|
|
class Client(object):
|
|
def __init__(self, *args, **kwargs):
|
|
"""Initialize a new http client for the monasca API."""
|
|
|
|
client = MonascaApi(*args, **kwargs)
|
|
|
|
self.metrics = metrics.MetricsManager(client)
|
|
self.notifications = notifications.NotificationsManager(client)
|
|
self.alarms = alarms.AlarmsManager(client)
|
|
self.alarm_definitions = ad.AlarmDefinitionsManager(client)
|
|
self.notificationtypes = nt.NotificationTypesManager(client)
|
|
|
|
|
|
class MonascaApi(api.BaseAPI):
|
|
SERVICE_TYPE = "monitoring"
|