94c5223f02
osc-lib library is foundation on which a CLI client for openstack can be built. It is meant to facilitate several aspects, that were previously hard-coded in client: * keystone communication handling * supporting multiple authentication methods (not only password) * common authentication parameters (i.e. environmental OS_*) * communicating over http with service endpoint * interactive CLI mode Thanks to those items, it was possible not only to drop nearly 3k lines of code and replace them with osc-lib but also increase reliabity of the client in terms of new openstack releases. Also it allowed to greatly simpify existing set of unit-tests. They are now testing only actual logic instead of mocking entire process of calling shell (i.e. MonascaShell.run(args)) or mocking HTTP communication. Both items are handled by osc-lib thus not they are not subject of monascaclient unit tests layers. Note: This change is partial integration with osc-lib and its main purpose is to move the responsibility of: * keystone communication * rest-ful communication with service endpoint to underlying library thus allowing client to implement only necessary functionality and not supporting boilerplate code, mentioned above. Story: 2000995 Task: 4172 Change-Id: I1712a24739438e2d8331a495f18f357749a633c5
62 lines
1.9 KiB
Python
62 lines
1.9 KiB
Python
# (C) Copyright 2014-2017 Hewlett Packard Enterprise Development LP
|
|
# Copyright 2017 FUJITSU LIMITED
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import mock
|
|
|
|
from oslotest import base
|
|
|
|
from monascaclient import shell
|
|
|
|
|
|
class TestMonascaShell(base.BaseTestCase):
|
|
|
|
@mock.patch('monascaclient.shell.auth')
|
|
def test_should_use_auth_plugin_option_parser(self, auth):
|
|
auth.build_auth_plugins_option_parser = apop = mock.Mock()
|
|
shell.MonascaShell().run([])
|
|
apop.assert_called_once()
|
|
|
|
def test_should_specify_monasca_args(self):
|
|
expected_args = [
|
|
'--monasca-api-url',
|
|
'--monasca-api-version',
|
|
'--monasca_api_url',
|
|
'--monasca_api_version',
|
|
]
|
|
|
|
parser = mock.Mock()
|
|
parser.add_argument = aa = mock.Mock()
|
|
shell.MonascaShell._append_monasca_args(parser)
|
|
|
|
aa.assert_called()
|
|
for mc in aa.mock_calls:
|
|
name = mc[1][0]
|
|
self.assertIn(name, expected_args)
|
|
|
|
@mock.patch('monascaclient.shell.importutils')
|
|
def test_should_load_commands_based_on_api_version(self, iu):
|
|
iu.import_versioned_module = ivm = mock.Mock()
|
|
|
|
instance = shell.MonascaShell()
|
|
instance.options = mock.Mock()
|
|
instance.options.monasca_api_version = version = mock.Mock()
|
|
|
|
instance._find_actions = mock.Mock()
|
|
|
|
instance._load_commands()
|
|
|
|
ivm.assert_called_once_with('monascaclient', version, 'shell')
|