openstack/python-neutronclient
Code Issues Proposed changes

Clean imports in code

Browse Source 
In some part in the code we import objects.
In the Openstack style guidelines they recommend to import only modules.

http://docs.openstack.org/developer/hacking/#imports

Change-Id: I22cb3fed9dc442eb90d54b876f7443522709e846
This commit is contained in:
Cao Xuan Hoang 2016-08-25 14:43:48 +07:00
parent 64e8c3e21a
commit 368af6c72f
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
neutronclient/tests/unit/test_cli20_extensions.py
View File

@ -15,18 +15,16 @@
import sys import sys
from neutronclient.neutron.v2_0.extension import ListExt from neutronclient.neutron.v2_0 import extension
from neutronclient.neutron.v2_0.extension import ShowExt from neutronclient.tests.unit import test_cli20
from neutronclient.tests.unit.test_cli20 import CLITestV20Base
from neutronclient.tests.unit.test_cli20 import MyApp
class CLITestV20Extension(CLITestV20Base): class CLITestV20Extension(test_cli20.CLITestV20Base):
id_field = 'alias' id_field = 'alias'
def test_list_extensions(self): def test_list_extensions(self):
resources = 'extensions' resources = 'extensions'
cmd = ListExt(MyApp(sys.stdout), None) cmd = extension.ListExt(test_cli20.MyApp(sys.stdout), None)
contents = [{'alias': 'ext1', 'name': 'name1', 'other': 'other1'}, contents = [{'alias': 'ext1', 'name': 'name1', 'other': 'other1'},
{'alias': 'ext2', 'name': 'name2', 'other': 'other2'}] {'alias': 'ext2', 'name': 'name2', 'other': 'other2'}]
ret = self._test_list_resources(resources, cmd, ret = self._test_list_resources(resources, cmd,
@ -41,7 +39,7 @@ class CLITestV20Extension(CLITestV20Base):
# -F option does not work for ext-show at the moment, so -F option # -F option does not work for ext-show at the moment, so -F option
# is not passed in the commandline args as other tests do. # is not passed in the commandline args as other tests do.
resource = 'extension' resource = 'extension'
cmd = ShowExt(MyApp(sys.stdout), None) cmd = extension.ShowExt(test_cli20.MyApp(sys.stdout), None)
args = [self.test_id] args = [self.test_id]
ext_alias = self.test_id ext_alias = self.test_id
self._test_show_resource(resource, cmd, ext_alias, args, fields=[]) self._test_show_resource(resource, cmd, ext_alias, args, fields=[])