openstack
/
python-neutronclient
Code Issues Proposed changes

Fix random failure of security group unit test 

CLITestV20SecurityGroupsJSON.test_extend_list_exceed_max_uri_len
fails randomly because this test uses query parameters and
the order of query parameters in a construct URL is not deterministic.
As a result the test failed randomly.
The test should use MyUrlComparator to compare URLs.
MyUrlComparator ignores the order parameters when comparing URLs.

Change-Id: I8a8116f45583102fa1351d17a1cc5174bdce3cc9
Closes-Bug: #1570689
This commit is contained in:
Akihiro Motoki 2016-04-15 12:41:49 +09:00
parent fc2950c2bb
commit 84aebc2973
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
neutronclient/tests/unit/test_cli20_securitygroup.py
View File

@ -307,7 +307,8 @@ class CLITestV20SecurityGroupsJSON(test_cli20.CLITestV20Base):
self.client.httpclient._check_uri_length(
mox.IgnoreArg()).AndReturn(None)
self.client.httpclient.request(
test_cli20.end_url(path, item['filter']),
test_cli20.MyUrlComparator(
test_cli20.end_url(path, item['filter']), self.client),
'GET',
body=None,
headers=mox.ContainsKeyValue(