openstack
/
python-neutronclient
Code Issues Proposed changes

Fix one remaining E125 error and remove it from ignore list 

E125 continuation line does not distinguish itself from next logical line

Also update the comment of H405 since multi line docstring is used
frequently in unit test documentation and it seems better to hold it
in the ignore list not temporarily.

Change-Id: Ic24e6cebe0aa531e5a4556d3e23c752358bf3696
This commit is contained in:
Akihiro Motoki 2015-03-23 15:57:37 +09:00 committed by Akihiro Motoki
parent d6cfd34e13
commit cdfcf3c153
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
neutronclient/tests/unit/test_cli20.py
View File

@ -641,9 +641,9 @@ class ClientV2UnicodeTestXML(ClientV2TestJson):
class CLITestV20ExceptionHandler(CLITestV20Base):
def _test_exception_handler_v20(
self, expected_exception, status_code, expected_msg,
error_type=None, error_msg=None, error_detail=None,
error_content=None):
self, expected_exception, status_code, expected_msg,
error_type=None, error_msg=None, error_detail=None,
error_content=None):
if error_content is None:
error_content = {'NeutronError': {'type': error_type,
'message': error_msg,

6
tox.ini
View File

@ -37,10 +37,8 @@ commands=
downloadcache = ~/cache/pip
[flake8]
# E125 continuation line does not distinguish itself from next logical line
#
# TODO Fix the following rules from hacking 0.9.x
# H405 multi line docstring summary not separated with an empty line
ignore = E125,H405
# (mutli line docstring is used in unit tests frequently)
ignore = H405
show-source = true
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools