From e254392e7de66becb818ee4794379ade6afa7ece Mon Sep 17 00:00:00 2001 From: Angus Lees Date: Tue, 12 Aug 2014 15:36:54 +1000 Subject: [PATCH] Remove incorrect super() call extension.ShowExt.get_parser called super() with the *parent* class, skipping the parent's own get_parser. This is quite surprising without any additional comments to explain the situation. The only difference between the two get_parsers is the string that appears in the usage help text (EXT_ALIAS vs EXTENSION). Rather than improve the above super() call, this change removes the specialised ShowExt.get_parser() implementation entirely since it appears the generic version is sufficient. Change-Id: I76b901d6a27fbe6f103baf2f03ea17912123a46b --- neutronclient/neutron/v2_0/extension.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/neutronclient/neutron/v2_0/extension.py b/neutronclient/neutron/v2_0/extension.py index 2c14d72eb..24905d59d 100644 --- a/neutronclient/neutron/v2_0/extension.py +++ b/neutronclient/neutron/v2_0/extension.py @@ -15,7 +15,6 @@ # from neutronclient.neutron import v2_0 as cmd_base -from neutronclient.openstack.common.gettextutils import _ class ListExt(cmd_base.ListCommand): @@ -30,11 +29,3 @@ class ShowExt(cmd_base.ShowCommand): resource = "extension" allow_names = False - - def get_parser(self, prog_name): - parser = super(cmd_base.ShowCommand, self).get_parser(prog_name) - cmd_base.add_show_list_common_argument(parser) - parser.add_argument( - 'id', metavar='EXT-ALIAS', - help=_('The extension alias.')) - return parser