18ce7d9f2e
assertEqual expects that the arguments provided to it should be (expected, observed).If a particluar order is kept as a convention, then it helps to provide a cleaner message to the developer if Unit Tests fail. There are several Unit Test files where the arguments for assertEqual have been swapped. This commit fixes the issue in python-neutronclient. Additionally instead of using assertEqual(True,xxx), assertTrue(xxx) should be used. The same has been fixed in this patch. Partial-Bug: #1259292 Related-Bug: #1259292 Change-Id: I83ec45af75f61f8005a60efc8176db0df5cfbe9a
43 lines
1.5 KiB
Python
43 lines
1.5 KiB
Python
# Copyright 2013 Intel
|
|
# Copyright 2013 Isaku Yamahata <isaku.yamahata at intel com>
|
|
# <isaku.yamahata at gmail com>
|
|
# All Rights Reserved.
|
|
#
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
import logging
|
|
|
|
import testtools
|
|
from testtools import helpers
|
|
|
|
from neutronclient.neutron import v2_0 as neutronV20
|
|
|
|
|
|
class TestCommandMeta(testtools.TestCase):
|
|
def test_neutron_command_meta_defines_log(self):
|
|
class FakeCommand(neutronV20.NeutronCommand):
|
|
pass
|
|
|
|
self.assertTrue(helpers.safe_hasattr(FakeCommand, 'log'))
|
|
self.assertIsInstance(FakeCommand.log, logging.getLoggerClass())
|
|
self.assertEqual(__name__ + ".FakeCommand", FakeCommand.log.name)
|
|
|
|
def test_neutron_command_log_defined_explicitly(self):
|
|
class FakeCommand(neutronV20.NeutronCommand):
|
|
log = None
|
|
|
|
self.assertTrue(helpers.safe_hasattr(FakeCommand, 'log'))
|
|
self.assertIsNone(FakeCommand.log)
|