openstack
/
python-novaclient
Code Issues Proposed changes

Merge "Fix AttributeError in Keypair._add_details()"

This commit is contained in:
Jenkins 2013-09-24 21:12:11 +00:00 committed by Gerrit Code Review
parent 991ab62ef1 9e8dd063c6
commit 2ab334435f
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
novaclient/v1_1/keypairs.py
View File

@ -32,7 +32,15 @@ class Keypair(base.Resource):
dico = 'keypair' in info and \
info['keypair'] or info
for (k, v) in dico.items():
setattr(self, k, v)
# NOTE(rpodolyaka): keypair name allows us to uniquely identify
# a specific keypair, while its id attribute
# is nothing more than an implementation
# detail. We can safely omit the id attribute
# here to ensure setattr() won't raise
# AttributeError trying to set read-only
# property id
if k != 'id':
setattr(self, k, v)
@property
def id(self):