openstack/python-novaclient
Code Issues Proposed changes

Merge "secgroup-create description is not optional"

Browse Source
This commit is contained in:
Jenkins 2014-09-17 22:34:24 +00:00 committed by Gerrit Code Review
commit 3e5dae84a8
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
novaclient/tests/v1_1/test_shell.py
View File

@ -1902,13 +1902,6 @@ class ShellTest(utils.TestCase):
{'name': 'test',
'description': 'FAKE_SECURITY_GROUP'}})
def test_security_group_create_without_description(self):
self.run_command('secgroup-create test')
self.assert_called('POST', '/os-security-groups',
{'security_group':
{'name': 'test',
'description': None}})
def test_security_group_update(self):
self.run_command('secgroup-update test te FAKE_SECURITY_GROUP')
self.assert_called('PUT', '/os-security-groups/1',

2
novaclient/v1_1/shell.py
View File

@ -2423,7 +2423,7 @@ def do_secgroup_delete_rule(cs, args):
@utils.arg('name', metavar='<name>', help=_('Name of security group.'))
@utils.arg('description', metavar='<description>', nargs='?',
@utils.arg('description', metavar='<description>',
help=_('Description of security group.'))
def do_secgroup_create(cs, args):
"""Create a security group."""