openstack/python-novaclient
Code Issues Proposed changes

functional: Handle multiple networks

Browse Source 
The 'TestServersBootNovaClient.test_boot_server_using_image_with' tests
in 'novaclient.tests.functional.v2.legacy.test_servers' was failing due
to multiple networks errors. Something has changed here, but I don't
know what and I haven't bisected to figure it out. However, this test
was the only one that wasn't respecting the 'multiple_networks'
attribute we set to detect exactly this issue. Change that, fixing the
test in the process.

Closes-bug: #2077168

Change-Id: If8384aaf138559fe83ba4485049f9a7b45a44e12
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2024-08-27 11:06:47 +01:00 committed by melanie witt
parent 2bd135c137
commit 3e63fb9dd9
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
novaclient/tests/functional/v2/legacy/test_servers.py
View File

@ -89,11 +89,15 @@ class TestServersBootNovaClient(base.ClientTestBase):
3. Create a second server using the --image-with option using the meta
key stored in the snapshot image created in step 2.
"""
# create the first server and wait for it to be active
server_info = self.nova('boot', params=(
params = (
'--flavor %(flavor)s --image %(image)s --poll '
'image-with-server-1' % {'image': self.image.id,
'flavor': self.flavor.id}))
'flavor': self.flavor.id})
# check to see if we have to pass in a network id
if self.multiple_networks:
params += ' --nic net-id=%s' % self.network.id
# create the first server and wait for it to be active
server_info = self.nova('boot', params=params)
server_id = self._get_value_from_the_table(server_info, 'id')
self.addCleanup(self._cleanup_server, server_id)
@ -114,11 +118,15 @@ class TestServersBootNovaClient(base.ClientTestBase):
snapshot_info, 'image_with_meta')
self.assertEqual(server_id, meta_value)
# create the second server using --image-with
server_info = self.nova('boot', params=(
params = (
'--flavor %(flavor)s --image-with image_with_meta=%(meta_value)s '
'--poll image-with-server-2' % {'meta_value': server_id,
'flavor': self.flavor.id}))
'flavor': self.flavor.id})
# check to see if we have to pass in a network id
if self.multiple_networks:
params += ' --nic net-id=%s' % self.network.id
# create the second server using --image-with
server_info = self.nova('boot', params=params)
server_id = self._get_value_from_the_table(server_info, 'id')
self.addCleanup(self._cleanup_server, server_id)