Browse Source

Enable H233

H233 (and H402) were temporarily disabled as part of the migration to
hacking 0.9. This patch fixes all H233 issues and re-enables
gating on them.

H402 has been removed in hacking
(I9426644fa708e9d5563abe04dc4ad656dbeb3656) so leave this one off as its
going away anyway.

Change-Id: Iae8f132c66c5e345dc2e9c2464f67609887c1475
Joe Gordon 4 years ago
parent
commit
4d2586716a
3 changed files with 4 additions and 4 deletions
  1. 1
    1
      novaclient/v1_1/shell.py
  2. 1
    1
      novaclient/v3/shell.py
  3. 2
    2
      tox.ini

+ 1
- 1
novaclient/v1_1/shell.py View File

@@ -507,7 +507,7 @@ def _poll_for_status(poll_fn, obj_id, action, final_ok_states,
507 507
         sys.stdout.flush()
508 508
 
509 509
     if not silent:
510
-        print
510
+        print()
511 511
 
512 512
     while True:
513 513
         obj = poll_fn(obj_id)

+ 1
- 1
novaclient/v3/shell.py View File

@@ -353,7 +353,7 @@ def _poll_for_status(poll_fn, obj_id, action, final_ok_states,
353 353
         sys.stdout.flush()
354 354
 
355 355
     if not silent:
356
-        print
356
+        print()
357 357
 
358 358
     while True:
359 359
         obj = poll_fn(obj_id)

+ 2
- 2
tox.ini View File

@@ -27,7 +27,7 @@ downloadcache = ~/cache/pip
27 27
 
28 28
 [flake8]
29 29
 # TODO fix following rules from hacking 0.9
30
-# E131,E265,H233,H402,H405,H904
31
-ignore = E12,E131,E265,F811,F821,H233,H302,H402,H404,H405,H904
30
+# E131,E265,H402,H405,H904
31
+ignore = E12,E131,E265,F811,F821,H302,H402,H404,H405,H904
32 32
 show-source = True
33 33
 exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,build

Loading…
Cancel
Save