From 4d2586716ada61b8087d2f95dfe2595f9c93cdc6 Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Mon, 16 Jun 2014 00:03:06 -0700 Subject: [PATCH] Enable H233 H233 (and H402) were temporarily disabled as part of the migration to hacking 0.9. This patch fixes all H233 issues and re-enables gating on them. H402 has been removed in hacking (I9426644fa708e9d5563abe04dc4ad656dbeb3656) so leave this one off as its going away anyway. Change-Id: Iae8f132c66c5e345dc2e9c2464f67609887c1475 --- novaclient/v1_1/shell.py | 2 +- novaclient/v3/shell.py | 2 +- tox.ini | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/novaclient/v1_1/shell.py b/novaclient/v1_1/shell.py index a08f92aad..ad1a23e16 100644 --- a/novaclient/v1_1/shell.py +++ b/novaclient/v1_1/shell.py @@ -507,7 +507,7 @@ def _poll_for_status(poll_fn, obj_id, action, final_ok_states, sys.stdout.flush() if not silent: - print + print() while True: obj = poll_fn(obj_id) diff --git a/novaclient/v3/shell.py b/novaclient/v3/shell.py index aa57ad8c9..44665a928 100644 --- a/novaclient/v3/shell.py +++ b/novaclient/v3/shell.py @@ -353,7 +353,7 @@ def _poll_for_status(poll_fn, obj_id, action, final_ok_states, sys.stdout.flush() if not silent: - print + print() while True: obj = poll_fn(obj_id) diff --git a/tox.ini b/tox.ini index d3a51ea9e..8b2408de1 100644 --- a/tox.ini +++ b/tox.ini @@ -27,7 +27,7 @@ downloadcache = ~/cache/pip [flake8] # TODO fix following rules from hacking 0.9 -# E131,E265,H233,H402,H405,H904 -ignore = E12,E131,E265,F811,F821,H233,H302,H402,H404,H405,H904 +# E131,E265,H402,H405,H904 +ignore = E12,E131,E265,F811,F821,H302,H402,H404,H405,H904 show-source = True exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,build