openstack/python-novaclient
Code Issues Proposed changes

Enable check for E124 rule

Browse Source 
Fix E124 failures and enable check for E124

E124 closing bracket does not match visual indentation

Change-Id: Iec6af44362dcf613cfaccbccbe53de82aba51a6a
This commit is contained in:
Sergey Nikitin 2015-02-27 16:29:30 +03:00
parent 7a1066fb79
commit 53f0c5428f
4 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
novaclient/tests/unit/test_client.py
View File

@ -316,12 +316,10 @@ class ClientTest(utils.TestCase):
cs.http_log_debug = True cs.http_log_debug = True
cs.http_log_req('GET', '/foo', {'headers': {}}) cs.http_log_req('GET', '/foo', {'headers': {}})
cs.http_log_req('GET', '/foo', {'headers': cs.http_log_req('GET', '/foo', {'headers':
{'X-Auth-Token': 'totally_bogus'} {'X-Auth-Token': 'totally_bogus'}})
})
cs.http_log_req('GET', '/foo', {'headers': cs.http_log_req('GET', '/foo', {'headers':
{'X-Foo': 'bar', {'X-Foo': 'bar',
'X-Auth-Token': 'totally_bogus'} 'X-Auth-Token': 'totally_bogus'}})
})
cs.http_log_req('GET', '/foo', {'headers': {}, cs.http_log_req('GET', '/foo', {'headers': {},
'data': 'data':
'{"auth": {"passwordCredentials": ' '{"auth": {"passwordCredentials": '

3
novaclient/tests/unit/test_http.py
View File

@ -97,8 +97,7 @@ class ClientTest(utils.TestCase):
headers = {"X-Auth-Token": "token", headers = {"X-Auth-Token": "token",
"X-Auth-Project-Id": "project_id", "X-Auth-Project-Id": "project_id",
"User-Agent": cl.USER_AGENT, "User-Agent": cl.USER_AGENT,
'Accept': 'application/json', 'Accept': 'application/json'}
}
mock_request.assert_called_with( mock_request.assert_called_with(
"GET", "GET",
"http://example.com/hi", "http://example.com/hi",

10
novaclient/tests/unit/v2/fakes.py
View File

@ -1359,9 +1359,9 @@ class FakeHTTPClient(base_client.HTTPClient):
# #
def get_os_security_group_rules(self, **kw): def get_os_security_group_rules(self, **kw):
return (200, {}, {"security_group_rules": [ return (200, {}, {"security_group_rules": [
{'id': 1, 'parent_group_id': 1, 'group_id': 2, {'id': 1, 'parent_group_id': 1, 'group_id': 2,
'ip_protocol': 'TCP', 'from_port': 22, 'to_port': 22, 'ip_protocol': 'TCP', 'from_port': 22, 'to_port': 22,
'cidr': '10.0.0.0/8'} 'cidr': '10.0.0.0/8'}
]}) ]})
def delete_os_security_group_rules_1(self, **kw): def delete_os_security_group_rules_1(self, **kw):
@ -1392,8 +1392,8 @@ class FakeHTTPClient(base_client.HTTPClient):
# #
def get_os_security_group_default_rules(self, **kw): def get_os_security_group_default_rules(self, **kw):
return (200, {}, {"security_group_default_rules": [ return (200, {}, {"security_group_default_rules": [
{'id': 1, 'ip_protocol': 'TCP', 'from_port': 22, {'id': 1, 'ip_protocol': 'TCP', 'from_port': 22,
'to_port': 22, 'cidr': '10.0.0.0/8'} 'to_port': 22, 'cidr': '10.0.0.0/8'}
]}) ]})
def delete_os_security_group_default_rules_1(self, **kw): def delete_os_security_group_default_rules_1(self, **kw):

2
tox.ini
View File

@ -45,7 +45,7 @@ downloadcache = ~/cache/pip
# Following checks are ignored on purpose. # Following checks are ignored on purpose.
# #
# Additional checks are also ignored on purpose: F811, F821 # Additional checks are also ignored on purpose: F811, F821
ignore = E124,F811,F821,H404,H405 ignore = F811,F821,H404,H405
show-source = True show-source = True
exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,build,doc/source/conf.py exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,build,doc/source/conf.py