openstack/python-novaclient
Code Issues Proposed changes

base.Resource not define __ne__() built-in function

Browse Source 
Class base.Resource defines __eq__() built-in function, but does
not define __ne__() built-in function, so self.assertEqual works
but self.assertNotEqual does not work at all in this test case in
python2. This patch fixes it by defining __ne__() built-in function
of class base.Resource. Also fixes spelling errors:resoruces.

Change-Id: I39e6f6b94e9490afc14143208e6f20b0ef960991
Closes-Bug: #1586268
This commit is contained in:
yuyafei 2016-07-04 15:30:56 +08:00 committed by Andrey Kurilin
parent d052f2609f
commit 55201c55a8
2 changed files with 4 additions and 1 deletions
novaclient
base.py
tests/unit
test_base.py

3
novaclient/base.py

@ -209,6 +209,9 @@ class Resource(RequestIdMixin):
return self.id == other.id return self.id == other.id
return self._info == other._info return self._info == other._info
def __ne__(self, other):
return not self.__eq__(other)
def is_loaded(self): def is_loaded(self):
return self._loaded return self._loaded

2
novaclient/tests/unit/test_base.py

@ -63,7 +63,7 @@ class BaseTest(utils.TestCase):
r2 = base.Resource(None, {'id': 1, 'name': 'hello'}) r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
self.assertEqual(r1, r2) self.assertEqual(r1, r2)
# Two resoruces of different types: never equal # Two resources of different types: never equal
r1 = base.Resource(None, {'id': 1}) r1 = base.Resource(None, {'id': 1})
r2 = flavors.Flavor(None, {'id': 1}) r2 = flavors.Flavor(None, {'id': 1})
self.assertNotEqual(r1, r2) self.assertNotEqual(r1, r2)