openstack/python-novaclient
Code Issues Proposed changes

Fix typo in novaclient

Browse Source 
hypen-separated --> hyphen-separated
overrwrite --> overwrite
typicaly --> typically
sematics --> semantics

Fixes bug: 1253881

Change-Id: I4aff614bb36b8f321837a9f54024b26ac0f11d40
This commit is contained in:
wingwj 2013-11-22 12:09:47 +08:00
parent c51dc4a525
commit 81c72dbc34
3 changed files with 5 additions and 5 deletions

6
novaclient/base.py

@ -110,7 +110,7 @@ class Manager(utils.HookableMixin):
try: try:
os.makedirs(cache_dir, 0o755) os.makedirs(cache_dir, 0o755)
except OSError: except OSError:
# NOTE(kiall): This is typicaly either permission denied while # NOTE(kiall): This is typically either permission denied while
# attempting to create the directory, or the # attempting to create the directory, or the
# directory already exists. Either way, don't # directory already exists. Either way, don't
# fail. # fail.
@ -125,7 +125,7 @@ class Manager(utils.HookableMixin):
try: try:
setattr(self, cache_attr, open(path, mode)) setattr(self, cache_attr, open(path, mode))
except IOError: except IOError:
# NOTE(kiall): This is typicaly a permission denied while # NOTE(kiall): This is typically a permission denied while
# attempting to write the cache file. # attempting to write the cache file.
pass pass
@ -290,7 +290,7 @@ class BootingManagerWithFind(ManagerWithFind):
:param meta: A dict of arbitrary key/value metadata to store for this :param meta: A dict of arbitrary key/value metadata to store for this
server. A maximum of five entries is allowed, and both server. A maximum of five entries is allowed, and both
keys and values must be 255 characters or less. keys and values must be 255 characters or less.
:param files: A dict of files to overrwrite on the server upon boot. :param files: A dict of files to overwrite on the server upon boot.
Keys are file names (i.e. ``/etc/passwd``) and values Keys are file names (i.e. ``/etc/passwd``) and values
are the file contents (either as a string or as a are the file contents (either as a string or as a
file-like object). A maximum of five entries is allowed, file-like object). A maximum of five entries is allowed,

2
novaclient/shell.py

@ -458,7 +458,7 @@ class OpenStackComputeShell(object):
def _find_actions(self, subparsers, actions_module): def _find_actions(self, subparsers, actions_module):
for attr in (a for a in dir(actions_module) if a.startswith('do_')): for attr in (a for a in dir(actions_module) if a.startswith('do_')):
# I prefer to be hypen-separated instead of underscores. # I prefer to be hyphen-separated instead of underscores.
command = attr[3:].replace('_', '-') command = attr[3:].replace('_', '-')
callback = getattr(actions_module, attr) callback = getattr(actions_module, attr)
desc = callback.__doc__ or '' desc = callback.__doc__ or ''

2
novaclient/utils.py

@ -42,7 +42,7 @@ def add_arg(f, *args, **kwargs):
# NOTE(sirp): avoid dups that can occur when the module is shared across # NOTE(sirp): avoid dups that can occur when the module is shared across
# tests. # tests.
if (args, kwargs) not in f.arguments: if (args, kwargs) not in f.arguments:
# Because of the sematics of decorator composition if we just append # Because of the semantics of decorator composition if we just append
# to the options list positional options will appear to be backwards. # to the options list positional options will appear to be backwards.
f.arguments.insert(0, (args, kwargs)) f.arguments.insert(0, (args, kwargs))