From 8c1d8fbe816f7650e9b8d201c30cfcbc6c0c2f4e Mon Sep 17 00:00:00 2001
From: Kevin_Zheng <zhengzhenyu@huawei.com>
Date: Tue, 12 Jul 2016 11:29:53 +0800
Subject: [PATCH] Correctly handle NOVACLIENT_INESCURE

Parameter insecure is read using env parameter
NOVACLIENT_INSECURE, this could be string, and
string is handled as True in the rest code,
which is not correct, we should transform it
into boolean to handle it correctly.

Change-Id: I536763e45b8399b394c7dfa92d327bb4bfaa509f
Closes-bug: #1602076
---
 novaclient/shell.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/novaclient/shell.py b/novaclient/shell.py
index 36b12f7e1..c740ea702 100644
--- a/novaclient/shell.py
+++ b/novaclient/shell.py
@@ -395,8 +395,8 @@ class OpenStackComputeShell(object):
         loading.register_auth_argparse_arguments(
             parser, argv, default=default_auth_plugin)
 
-        parser.set_defaults(insecure=utils.env('NOVACLIENT_INSECURE',
-                            default=False))
+        parser.set_defaults(insecure=strutils.bool_from_string(
+            utils.env('NOVACLIENT_INSECURE', default=False)))
         parser.set_defaults(os_auth_url=utils.env('OS_AUTH_URL', 'NOVA_URL'))
 
         parser.set_defaults(os_username=utils.env('OS_USERNAME',