openstack/python-novaclient
Code Issues Proposed changes

aggregate-details changed to aggregate-show

Browse Source 
To show details of aggregate, we have
aggregate-details command. But all other
commands to show details of any resource
is *-show like flavor-show, keypair-show etc.

So changed the command to aggregate-show.

Change-Id: If4875833a27382a6f3193ec55d6d4cb1852249fd
Closes-Bug: #1552646
This commit is contained in:
abhishek.talwar 2016-03-14 15:10:11 +05:30
parent a7bffe8a71
commit bf68a0cf10
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
novaclient/tests/unit/v2/test_shell.py
View File

@ -1666,6 +1666,14 @@ class ShellTest(utils.TestCase):
self.run_command('aggregate-details test') self.run_command('aggregate-details test')
self.assert_called('GET', '/os-aggregates') self.assert_called('GET', '/os-aggregates')
def test_aggregate_show_by_id(self):
self.run_command('aggregate-show 1')
self.assert_called('GET', '/os-aggregates/1')
def test_aggregate_show_by_name(self):
self.run_command('aggregate-show test')
self.assert_called('GET', '/os-aggregates')
def test_live_migration(self): def test_live_migration(self):
self.run_command('live-migration sample-server hostname') self.run_command('live-migration sample-server hostname')
self.assert_called('POST', '/servers/1234/action', self.assert_called('POST', '/servers/1234/action',

8
novaclient/v2/shell.py
View File

@ -3779,6 +3779,14 @@ def do_aggregate_remove_host(cs, args):
'aggregate', metavar='<aggregate>', 'aggregate', metavar='<aggregate>',
help=_('Name or ID of aggregate.')) help=_('Name or ID of aggregate.'))
def do_aggregate_details(cs, args): def do_aggregate_details(cs, args):
"""DEPRECATED, use aggregate-show instead."""
do_aggregate_show(cs, args)
@utils.arg(
'aggregate', metavar='<aggregate>',
help=_('Name or ID of aggregate.'))
def do_aggregate_show(cs, args):
"""Show details of the specified aggregate.""" """Show details of the specified aggregate."""
aggregate = _find_aggregate(cs, args.aggregate) aggregate = _find_aggregate(cs, args.aggregate)
_print_aggregate_details(aggregate) _print_aggregate_details(aggregate)