From 437b08cf38f836798d51b9736c5af9217f925897 Mon Sep 17 00:00:00 2001
From: Stephen Finucane <sfinucan@redhat.com>
Date: Tue, 4 Jul 2017 17:35:31 +0100
Subject: [PATCH] Remove custom autodoc implementation

pbr provides this functionality for us. Make use of it.

Change-Id: Ide7b2992ac931395b776d39ed4a1a50bded0a881
---
 doc/source/conf.py                 | 65 +-----------------------------
 doc/source/reference/api/index.rst |  3 +-
 novaclient/utils.py                |  9 +++--
 setup.cfg                          |  5 +++
 4 files changed, 13 insertions(+), 69 deletions(-)

diff --git a/doc/source/conf.py b/doc/source/conf.py
index 46a7ae337..c252baab1 100644
--- a/doc/source/conf.py
+++ b/doc/source/conf.py
@@ -12,69 +12,6 @@
 #
 # python-novaclient documentation build configuration file
 
-import os
-import sys
-
-BASE_DIR = os.path.dirname(os.path.abspath(__file__))
-ROOT = os.path.abspath(os.path.join(BASE_DIR, "..", ".."))
-
-sys.path.insert(0, ROOT)
-sys.path.insert(0, BASE_DIR)
-
-
-# TODO(stephenfin): This looks like something that pbr's autodoc integration
-# could be doing for us. Investigate.
-
-def gen_ref(ver, title, names):
-    refdir = os.path.join(BASE_DIR, "reference", "api")
-    pkg = "novaclient"
-    if ver:
-        pkg = "%s.%s" % (pkg, ver)
-        refdir = os.path.join(refdir, ver)
-    if not os.path.exists(refdir):
-        os.makedirs(refdir)
-
-    # we don't want to write index files for top-level directories - only
-    # sub-directories
-    if ver:
-        idxpath = os.path.join(refdir, "index.rst")
-        with open(idxpath, "w") as idx:
-            idx.write(("%(title)s\n"
-                       "%(signs)s\n"
-                       "\n"
-                       ".. toctree::\n"
-                       "   :maxdepth: 1\n"
-                       "\n") % {"title": title, "signs": "=" * len(title)})
-            for name in names:
-                idx.write("   %s\n" % name)
-
-    for name in names:
-        rstpath = os.path.join(refdir, "%s.rst" % name)
-        with open(rstpath, "w") as rst:
-            rst.write(("%(title)s\n"
-                       "%(signs)s\n"
-                       "\n"
-                       ".. automodule:: %(pkg)s.%(name)s\n"
-                       "   :members:\n"
-                       "   :undoc-members:\n"
-                       "   :show-inheritance:\n"
-                       "   :noindex:\n")
-                      % {"title": name.capitalize(),
-                         "signs": "=" * len(name),
-                         "pkg": pkg, "name": name})
-
-
-def get_module_names():
-    names = os.listdir(os.path.join(ROOT, 'novaclient', 'v2'))
-    exclude = ['shell.py', '__init__.py']
-    for name in names:
-        if name.endswith('.py') and name not in exclude:
-            yield name.strip('.py')
-
-
-gen_ref(None, "Exceptions", ["exceptions"])
-gen_ref("v2", "Version 2 API", sorted(get_module_names()))
-
 # -- General configuration ----------------------------------------------------
 
 # Add any Sphinx extension module names here, as strings. They can be
@@ -84,6 +21,8 @@ extensions = [
     'openstackdocstheme',
 ]
 
+# The content that will be inserted into the main body of an autoclass
+# directive.
 autoclass_content = 'both'
 
 # Add any paths that contain templates here, relative to this directory.
diff --git a/doc/source/reference/api/index.rst b/doc/source/reference/api/index.rst
index c5ed6d885..e7b11e491 100644
--- a/doc/source/reference/api/index.rst
+++ b/doc/source/reference/api/index.rst
@@ -106,5 +106,4 @@ For more information, see the reference:
 .. toctree::
    :maxdepth: 2
 
-   v2/index
-   exceptions
+   autoindex
diff --git a/novaclient/utils.py b/novaclient/utils.py
index e93df6999..451b2372d 100644
--- a/novaclient/utils.py
+++ b/novaclient/utils.py
@@ -103,8 +103,11 @@ def add_arg(func, *args, **kwargs):
 
 def service_type(stype):
     """Adds 'service_type' attribute to decorated function.
+
     Usage:
+
     .. code-block:: python
+
        @service_type('volume')
        def mymethod(f):
        ...
@@ -436,11 +439,9 @@ def record_time(times, enabled, *args):
     """Record the time of a specific action.
 
     :param times: A list of tuples holds time data.
-    :type times: list
     :param enabled: Whether timing is enabled.
-    :type enabled: bool
-    :param *args: Other data to be stored besides time data, these args
-                  will be joined to a string.
+    :param args: Other data to be stored besides time data, these args
+        will be joined to a string.
     """
     if not enabled:
         yield
diff --git a/setup.cfg b/setup.cfg
index 5aa68c2bc..3a8087ff3 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -39,6 +39,11 @@ build-dir = doc/build
 [upload_sphinx]
 upload-dir = doc/build/html
 
+[pbr]
+autodoc_index_modules = True
+autodoc_exclude_modules = novaclient.tests.* novaclient.v2.contrib.*
+api_doc_dir = reference/api
+
 [compile_catalog]
 domain = novaclient
 directory = novaclient/locale