openstack/python-novaclient
Code Issues Proposed changes

Merge "Make "policy" a mandatory argument for server-group-create"

Browse Source
This commit is contained in:
Jenkins 2016-10-19 10:22:33 +00:00 committed by Gerrit Code Review
commit f5647e35c3
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
novaclient/v2/shell.py
View File

@ -5050,27 +5050,13 @@ def do_secgroup_delete_default_rule(cs, args):
@utils.arg('name', metavar='<name>', help=_('Server group name.')) @utils.arg('name', metavar='<name>', help=_('Server group name.'))
# NOTE(wingwj): The '--policy' way is still reserved here for preserving
# the backwards compatibility of CLI, even if a user won't get this usage
# in '--help' description. It will be deprecated after a suitable deprecation
# period(probably 2 coordinated releases or so).
#
# Moreover, we imagine that a given user will use only positional parameters or
# only the "--policy" option. So we don't need to properly handle
# the possibility that they might mix them here. That usage is unsupported.
# The related discussion can be found in
# https://review.openstack.org/#/c/96382/2/.
@utils.arg( @utils.arg(
'policy', 'policy',
metavar='<policy>', metavar='<policy>',
default=argparse.SUPPRESS, nargs='+',
nargs='*',
help=_('Policies for the server groups.')) help=_('Policies for the server groups.'))
def do_server_group_create(cs, args): def do_server_group_create(cs, args):
"""Create a new server group with the specified details.""" """Create a new server group with the specified details."""
if not args.policy:
raise exceptions.CommandError(_("at least one policy must be "
"specified"))
kwargs = {'name': args.name, kwargs = {'name': args.name,
'policies': args.policy} 'policies': args.policy}
server_group = cs.server_groups.create(**kwargs) server_group = cs.server_groups.create(**kwargs)