The bash completion code is the sole user of the slugify() function
in utils, which is substantially similar to to_slug() provided in
strutils from oslo.
Change-Id: Ib4eb7e4c0fa0e9bc5c4a0856f6391911d8f8fd3b
Closes-bug: #1266118
Instead of using novaclient.utils' bool_from_str, use bool_from_string
from the oslo incubating strutils
Notes:
0. utils.bool_from_str was strict, only accepted a small set of
values, while strutils.bool_from_string is not strict by default,
anything not true is false
1. bool_from_string accepts on/off, which bool_from_str did not
Change-Id: I04744844b55697819289def081d3c9117ed0713f
'nova aggregate-details' shows Hosts, Availability Zone
and Metadata in the python unicode notation.
+ Adds some tests about aggregates ported from v1 to the
v3 shell
Change-Id: I69d80b2e76833d78248dee782ae5e53f42a4f4a9
Closes-Bug: #1132961
Flatten the nested dicts so that hypervisor information can be more
easily used at the command line.
Change-Id: I5dfcf9d10f917a63bde09f0b5a691784a5e8f02b
Closes-bug: #1243512
'nova aggregate-details' shows Hosts, Availability Zone
and Metadata in the python unicode notation.
Change-Id: If0028347146439994265c60c429af05dd67912f9
Closes-Bug: #1132961
1. strutils.safe_encode() return "bytes" in py33.
2. find_resource() makes use of uuid.UUID() to verify the given
uuid argument, uuid.UUID() will trigger TypeError when input is
"bytes".
so, decode the bytes before uuid.UUID() while run in Python 3.
Close-bug #1232445
Change-Id: I504be7b43236b3a4843655706385e506cd559e4e
Python 2:
str.encode = encode(...)
S.encode([encoding[,errors]]) -> object
Python 3:
str.encode = encode(...)
S.encode(encoding='utf-8', errors='strict') -> bytes
In Python 3, strings are always Unicode. safe_encode() returns
"bytes", the "\n" will be printed literally, it is not expected.
bytes.decode() will transform bytes to str, which will be printed
properly.
Close-bug: #1229150
Change-Id: If926d3f7837673b4608ae667d34cea3c78e82e5d
Python3 uses the the concepts of text and (binary) data
instead of Unicode strings and 8-bit strings. In python3
all text is unicode; however encoded unicode is represented
as binary data.
Use the six module to use six.binary_types and six.text_types
where apporiate:
- six.text_type unicode() in python2 and str in python3.
- six.basestring() in python2 and str in python3.
blueprint python3-novaclient
Change-Id: Ie7b393abe6beac22eaf127b7fc7bbc372c338211
Signed-off-by: Chuck Short <chuck.short@canonical.com>
While running the unit tests with python3 the following
traceback appears:
TypeError: can't use a string pattern on a bytes-like object
This is due to the way that python2 and python3 handles unicodes.
Change-Id: I401f1cefed69780073222cae98d8da4c3d8031a8
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Administrator cannot use the flavor name in arguments of
"nova flavor-access-add" and "nova flavor-access-remove".
This patch fixes this problem.
Change-Id: I68b267dc071382f1978efc2088cd8e837455e8b4
Related-Bug: #1205298
Administrator cannot use the flavor name in arguments of
"nova flavor-access-add" and "nova flavor-access-remove"
in following conditions.
1. The flavor is non-public.
2. The falvor doesn't belong administrator's tenant.
This patch fixes this problem.
Change-Id: Ic5e3222d0ff62667e003a61e6a94e85833da5d11
Fixes: bug #1205298
In python3 dict.iteritems(), dict.iterkeys(), and
dict.itervalues() are no longer supported. So use
six.iteritems() where it is appropriate.
Change-Id: I8b07dc2a89d790ec275d45f859e1644e9b00c837
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Python3 enforces the distinction between byte strings and text strings
more rigorously than python2. So use six.text_type/six.u()
where appropriate
Change-Id: I890e19cb857e10f0292aabdaebaa8e7a7bd8db23
Signed-off-by: Chuck Short <chuck.short@canonical.com>
In the original code, isalnum() in is_uuid_like() doesn't allow "-",
while for UUID, format like aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa should be
allowed. This patch is to reuse uuidutils's API in oslo.
Change-Id: I339974c75a32d27f8e4443a1b97bb6e410933aa4
Signed-off-by: Shane Wang <shane.wang@intel.com>
Some cleanups include:
- Add flavor sub-commands into README.rst
- Check flavor ID when creating a flavor
- Remove check_uuid_like() because it isn't used
- Remove parameter cs in some _print_XXX functions because cs is
not used
Change-Id: If47ce557d33db05f53e382f0670f436e05a340b7
Signed-off-by: Shane Wang <shane.wang@intel.com>
Because sort_index = 0 by default, "if sort_index is not None" doesn't
make any sense.
Here sort_index should be None by default, which means "donot want to
sort".
Change-Id: I823ab75eb7a92bdc426dd96a3d1e56f187118729
Signed-off-by: Shane Wang <shane.wang@intel.com>
The current auth plugin system lacks some functionality to be used with
other methods that might require additional configuration options or
that do not require a user to pass some options that are now compulsory
(for example, X.509 authentication needs to get a certificate file, and
does not need either a username or a password). This commit extends
the current system to handle these extra features, while remaining
compatible with older plugins.
DocImpact: We should documment how to implement additional
authentication plugins, such as BasicAuth, X509, etc.
Implements: blueprint authentication-plugins
Change-Id: I7b0ef4981efba8160dea94bf852dba7e2e4068f5
When using Keystone PKI, a token ID can be over 3200 chars long.
Add optional --wrap option to make 'keystone token-get' human readable
By default wrap=64 (to fit in 80 char terminal). And can be turned off by
setting wrap=0
Fix bug 1131001
Change-Id: I50be7ebb4323ab1bf07af557403f5136b49080a4
Currently novaclient doesn't handle properly incoming and outgoing
encode / decode process. As a solution for this, this patch implements a
decoding process for all data incoming from the user side and decodes
everything going out of the client, i.e: http requests, prints, etc.
This patch introduces a new module (strutils.py) taken from
oslo-incubator in order to use 2 of the functions present in it:
About safe_(decode|encode):
Both functions try to encode / decode the incoming text using the
stdin encoding, fallback to python's default encoding if that
returns None or to UTF-8 as the last option.
In both functions only basestring objects are accepted and they both
raise TypeError if an object of another type is passed.
About the general novaclient changes:
In order to better support non-ASCII characters, it is a good
practice to use unicode interanlly and encode everything that has to
go out. This patch aims to do that and introduces this behaviour in
the client.
Testing:
A good test (besides using tox) is to use nova client with and
without setting any locale (export LANG=).
Fixes bug: 1061156
Change-Id: I20b75e42b0c3dac89f1048faa1127253a64f86c7
Adds a --fields argument that sets the fields to display.
ID is always displayed.
Fixes bug #1076473
Change-Id: If3462e6a490ea16da4834a7f40f96b111c9e8227
Fix bug 1088835
"nova quota-update" command is executed without checking the format of
the tenant_id argument. The tenant_id should be in the format of UUID.
The tenant_id of quotas should be in accord with the form of keystone's
tenant_id. So this patch checks the format of the tenant_id when "nova
quota-update" command is executed.
Change-Id: I47c4f2ff9adbab5da4697270dcf024ac88e24529
When printing a dict e.g. "nova show" one of the properties
is "fault". When the user is admin, "details" of the fault
is shown, which includes a backtrace. This causes the
printing of the table to be unreadable as the backtrace
overflows the table row. This patch adds a separate row
for each substring after splitting on newlines.
Change-Id: I4c1bc8725a2bb6970be2c884c5e044d9eade8302
Ensure list printing function in utils can handle non-sorting
calls. Allow result list can be formatted and outputted without any
sorting field, keep natural order to the list printing. Adding necessary
checking to avoid prettytable (0.6.1 for me) exception: "Invalid field
name: None!".
Fix bug: #1099732
Change-Id: Ied869d987e608fff8b8b5f5a65d21e02f0cebeaa
Signed-off-by: zhiyanliu <lzy.dev@gmail.com>
Fixes the novaclient.utils.find_resource function to properly handle
non integer values and not break with an AttributeError.
Adds a test case to test a few more non valid inputs.
Fixes bug #1065367
Change-Id: Iaa2025f4eb580234f754596c3572e2f87872170e
Ensure that values which are supposed to be boolean look like correct
user input, instead of assuming that any non true-looking input is
False.
Also, update the flavor manager to raise a CommandError if is_public is
not a boolean value.
Fixes bug 1059414
Change-Id: I3275e4bba103b14081becf91f723f1be060391e5
blueprint project-specific-flavors
This change implements client bindings for the project specific flavor API in following change
https://review.openstack.org/#/c/11270/
Change-Id: Id8d559985f9369f53926e63ee5f5ce23a051e25b
The 'name' field for some resources is called something different,
for example 'display_name' for volumes. There was a hack in our
find method to search for display_name as well.
This change adds a new class variable to a Resource to tell it
which attribute to use for searching by name. Volumes and snapshots
were switched to use 'display_name' and hypervisors were switched
to use 'hypervisor_hostname'.
Tests fixed and added.
Fixes bug 1034536
Change-Id: I1b4fb969d42c59d1ab8e3e275a563bbe158e9264
