Fix E124 failures and enable check for E124
E124 closing bracket does not match visual indentation
Change-Id: Iec6af44362dcf613cfaccbccbe53de82aba51a6a
debugging tests is a lot easier when you can actually inject stderr
directly through even on successes. Add the pretty tox facility from
nova / tempest-lib into python-nova client as well for functional
tests.
Change-Id: I5c1f8244a5c743b590b74a8eb3eaf4a699555644
Begin moving tempest nova CLI tests out of tempest and into this repo
using tempest-lib. This patch adds the framework to run the functional
tests, later patches will port the existing tempest tests.
Use standard OpenStack environment variables to get keystone auth
Change-Id: Ie957bd450bfed97b63788cfb488f92988fbbc889
Fix E128 failures in novaclient/client and
novaclient/shell and enable check for E128
E128 continuation line under-indented for visual indent
Change-Id: Id3ac46ccdbb8a9f97e54b4643240d93b06fac6ea
I367064ecaa6d1fd9d918f7ce003303e2db660647 Added E12 to the
ignored on purpose list, which also makes no sense E12 was never meant
to be skipped all together (I was the one who added E12 to the flake8
ignore list (Ifc8924914b5a0d625bc8df6442ee85eb21459cde)
Then I4cf246e3ec932ba0d2391eb8bcb793b28b005b4c came along and updated
the list to break out the E12 ignored on purpose list.
Drop all E12 rules from the ignored on purpose list, as we do not want
to ignore these on purpose.
Change-Id: Ic400047347a82aebbc0f6ce6f5061e7757a02d3d
Module gettextutils from oslo-incubator was graduated to separate
library (oslo.i18n) and removed from repository, so we should use
new library.
Change-Id: I15d36ac5a2bb88b332ffa38d29488b75c55a20a9
Bring over the cleaning line from run_tests.sh for the pyc files to
all the tox runs.
This should eliminate the need to clean -x -i to kill pyc files in
your local directory to get tests to pass.
Related-Bug: #1368661
Change-Id: I00ee418eea2d82031bb510b09e63e2ec87fb1b09
* E265 block comment should start with '# '
* H302 import only modules
Do not check docs/source/conf.py. The file is imported from the
cookiecutter template.
Documented why checks are ignored and if they should be enabled
in the future.
Change-Id: I367064ecaa6d1fd9d918f7ce003303e2db660647
H233 (and H402) were temporarily disabled as part of the migration to
hacking 0.9. This patch fixes all H233 issues and re-enables
gating on them.
H402 has been removed in hacking
(I9426644fa708e9d5563abe04dc4ad656dbeb3656) so leave this one off as its
going away anyway.
Change-Id: Iae8f132c66c5e345dc2e9c2464f67609887c1475
F841 detects local variable is assigned to but never used.
This commit fix the violations and enable F841 in gate.
Change-Id: I52419f5e17db70e511ff2d4d61c85458c958e9c3
In order to keep this patch to just a requirements bump, ignore new and
stricter hacking rules that are being triggered. Fixing up the code and
turning these on is out of scope of this patch and is for future
patches.
Change-Id: Ia3517e705f894b48585b957c21e7a3a6ed90e586
Add posargs to flake8 call in tox.ini, with this you can pass arguments
directly into flake8 using the following notation
tox -epep8 -- --FLAKE8-ARG
This can be used to pass arguments like '--statistics' to flake8
Change-Id: Ia820d62c4a1f428d60d88b04d8a4d9b1442baa09
Ubuntu 14.04 has python 3.4 so add a 3.4 target.
Note that this will fail unless
you have new enough virtualenv. Recommend you install the packaged
version of 1.11.4 and get rid of any pip installed ones.
Change-Id: Ib54dc49fca2463f1c5cd788b48d06bd85be52655
A recent release of setuptools appears to have introduced a bug that
causes the pypy gate tests to fail. This applies a temporary workaround
that should restore pypy testing while the root cause of the problem is
researched.
Change-Id: I66597e40c1d2e57cca1292844d228af85214197d
Partial-Bug: 1290562
* tox.ini: The LANG and LANGUAGE environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug.
Change-Id: I0f30b45033145c61ad2a9b232cb1178c48c7fc97
Directory doc is excluded from pep8 check in tox.ini, since we
modified file doc/source/config.py, we should enable the check.
Change-Id: I057f1e6cb1c5f9a6a07043056078e4475f66f288
Updates tox.ini to reduce ignored rules.
Updates novaclient/v1_1/shell.py and
novaclient/v3/shell.py for E712 violation.
Change-Id: Ibfd6a4ed19835e65cc9e27873699c31a801e99a8
tox 1.6 allows us to skip the sdist step, which
is slow. This does that.
It also allows us to override the install line.
In this case, it's important as it allows us to
stop getting pre-release software we were not
asking for.
Original patch by Monty Taylor, talked about here:
http://lists.openstack.org/pipermail/openstack-dev/2013-September/015495.html
Change-Id: Iddf85d33b57f256d72756b516c23492e9600bedc
Introduce py33 to tox.ini to make testing with
python3 easier.
Change-Id: I2f339a2ccf113ff14db64c2bbc67a93bd0270962
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Only blacklisting those warnings that are numerous,
so that in principle Hacking and PyFlakes warnings
are tested. Fix the easy ones alongway.
Change-Id: I571f51ebf570ac114509f2dcd71cdce281e7c70a
The python community groks requirements.txt and test-requirements.txt as
reasonably standard files. We should use those filenames to make our
information more discoverable.
Fixes bug 1179008
Change-Id: I50a7c46f880e4257fa31d7d322d7bf70b0f5d3a6
openstack.common.setup and openstack.common.version are now in the
standalone library pbr, so all projects using those two should
migrate.
Fixes bug 1179007.
Change-Id: I7ac1c37f0bf148619dffff8f454db05fc192e471
There's no need to run pep8 on the build dir, and it contains E502 false
positives due to some part of the build process adding line
continuations in places that they're not needed.
Change-Id: I7ea19aea2b9e46503aa8acc06ce6b9d7ea18113a
Sergey Nikitin