4f16fe65c4
Currently there is a baked in assumption throughout the nova ecosystem
that endpoint urls will end in {project_id}.
This means that the version document for a specific major API version
is "endpoint - last_chunk_of_url". This is not a discoverable URL,
it's one that we heuristically generate.
GET /v2.1/{project_id} is a 404.
If we make Nova able to handle endpoint ids without {project_id} we
run into a problem with novaclient, which is that end_point is now
/v2.1. The heuristic gives us a version url of /. Which returns a very
different doc than /v2.1. This causes all novaclient commands to explode.
In order to support this transition we need to make both Nova and
Novaclient handle endpoints with and without {project_id}.
The proposal is thus to try the raw value of the endpoint first. If it
works, great. If it fails with a 404, fall back to the heuristics.
While this change and the nova change are technically independent, we
should land this one as soon as possible, because clients before this
change will not work with Nova deploys that get rid of project_id in
their service catalog in the future.
Part of bp:service-catalog-tng
Co-Authored-By: Augustina Ragwitz <aragwitz+lp@pobox.com>
Change-Id: Id4a2f73cbcfcf36aea750375fd92b1c2d3cd824e
104 lines
4.1 KiB
Python
104 lines
4.1 KiB
Python
# Copyright 2014 NEC Corporation. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
"""
|
|
version interface
|
|
"""
|
|
|
|
from six.moves import urllib
|
|
|
|
from novaclient import base
|
|
from novaclient import client
|
|
from novaclient import exceptions as exc
|
|
|
|
|
|
class Version(base.Resource):
|
|
"""
|
|
Compute REST API information
|
|
"""
|
|
def __repr__(self):
|
|
return "<Version>"
|
|
|
|
|
|
class VersionManager(base.ManagerWithFind):
|
|
resource_class = Version
|
|
|
|
def _is_session_client(self):
|
|
return isinstance(self.api.client, client.SessionClient)
|
|
|
|
def _get_current(self):
|
|
"""Returns info about current version."""
|
|
# TODO(sdague): we've now got to make up to 3 HTTP requests to
|
|
# determine what version we are running, due to differences in
|
|
# deployments and versions. We really need to cache the
|
|
# results of this per endpoint and keep the results of it for
|
|
# some reasonable TTL (like 24 hours) to reduce our round trip
|
|
# traffic.
|
|
if self._is_session_client():
|
|
try:
|
|
# Assume that the value of get_endpoint() is something
|
|
# we can get the version of. This is a 404 for Nova <
|
|
# Mitaka if the service catalog contains project_id.
|
|
#
|
|
# TODO(sdague): add microversion for when this will
|
|
# change
|
|
url = "%s" % self.api.client.get_endpoint()
|
|
return self._get(url, "version")
|
|
except exc.NotFound:
|
|
# If that's a 404, we can instead try hacking together
|
|
# an endpoint root url by chopping off the last 2 /s.
|
|
# This is kind of gross, but we've had this baked in
|
|
# so long people got used to this hard coding.
|
|
#
|
|
# NOTE(sdague): many service providers don't really
|
|
# implement GET / in the expected way, if we do a GET
|
|
# /v2 that's actually a 300 redirect to
|
|
# /v2/... because of how paste works. So adding the
|
|
# end slash is really important.
|
|
url = "%s/" % url.rsplit("/", 1)[0]
|
|
return self._get(url, "version")
|
|
else:
|
|
# NOTE(andreykurilin): HTTPClient doesn't have ability to send get
|
|
# request without token in the url, so `self._get` doesn't work.
|
|
all_versions = self.list()
|
|
url = self.client.management_url.rsplit("/", 1)[0]
|
|
for version in all_versions:
|
|
for link in version.links:
|
|
if link["href"].rstrip('/') == url:
|
|
return version
|
|
|
|
def get_current(self):
|
|
try:
|
|
return self._get_current()
|
|
except exc.Unauthorized:
|
|
# NOTE(sdague): RAX's repose configuration blocks access to the
|
|
# versioned endpoint, which is definitely non-compliant behavior.
|
|
# However, there is no defcore test for this yet. Remove this code
|
|
# block once we land things in defcore.
|
|
return None
|
|
|
|
def list(self):
|
|
"""List all versions."""
|
|
|
|
version_url = None
|
|
if self._is_session_client():
|
|
# NOTE: "list versions" API needs to be accessed without base
|
|
# URI (like "v2/{project-id}"), so here should be a scheme("http",
|
|
# etc.) and a hostname.
|
|
endpoint = self.api.client.get_endpoint()
|
|
url = urllib.parse.urlparse(endpoint)
|
|
version_url = '%s://%s/' % (url.scheme, url.netloc)
|
|
|
|
return self._list(version_url, "versions")
|