75fcc4b4e9
Something must have changed either with cliff or with a different version of python. All of the cli commands end with: "'Namespace' object is not subscriptable" This is caused because of how the parsed_args fields were accessed. This patch addresses the issue. Now it accesses the fields the same way as aodhclient does. The unit tests for cli now use the arg parser to actually test this. During this I also discovered incorrect mocking in the configuration tests. I added another mock to the test cases which were missing it. Change-Id: Ib5dbbdb48bdfd3214ec76acc4c68649e25f695db
131 lines
5.2 KiB
Python
131 lines
5.2 KiB
Python
# Copyright 2023 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import os
|
|
from unittest import mock
|
|
|
|
import testtools
|
|
|
|
from observabilityclient import prometheus_client
|
|
from observabilityclient.utils import metric_utils
|
|
|
|
|
|
class GetConfigFileTest(testtools.TestCase):
|
|
def setUp(self):
|
|
super(GetConfigFileTest, self).setUp()
|
|
|
|
def test_current_dir(self):
|
|
with mock.patch.object(os.path, 'exists', return_value=True), \
|
|
mock.patch.object(metric_utils, 'open') as m:
|
|
metric_utils.get_config_file()
|
|
m.assert_called_with(metric_utils.CONFIG_FILE_NAME, 'r')
|
|
|
|
def test_path_order(self):
|
|
expected = [mock.call(metric_utils.CONFIG_FILE_NAME, 'r'),
|
|
mock.call((f"{os.environ['HOME']}/.config/openstack/"
|
|
f"{metric_utils.CONFIG_FILE_NAME}")),
|
|
mock.call((f"/etc/openstack/"
|
|
f"{metric_utils.CONFIG_FILE_NAME}"))]
|
|
with mock.patch.object(os.path, 'exists', return_value=False) as m:
|
|
ret = metric_utils.get_config_file()
|
|
m.call_args_list == expected
|
|
self.assertIsNone(ret)
|
|
|
|
|
|
class GetPrometheusClientTest(testtools.TestCase):
|
|
def setUp(self):
|
|
super(GetPrometheusClientTest, self).setUp()
|
|
config_data = 'host: "somehost"\nport: "1234"'
|
|
self.config_file = mock.mock_open(read_data=config_data)("name", 'r')
|
|
|
|
def test_get_prometheus_client_from_file(self):
|
|
with mock.patch.object(metric_utils, 'get_config_file',
|
|
return_value=self.config_file), \
|
|
mock.patch.object(prometheus_client.PrometheusAPIClient,
|
|
"__init__", return_value=None) as m:
|
|
metric_utils.get_prometheus_client()
|
|
m.assert_called_with("somehost:1234")
|
|
|
|
def test_get_prometheus_client_env_overide(self):
|
|
with mock.patch.dict(os.environ, {'PROMETHEUS_HOST': 'env_overide'}), \
|
|
mock.patch.object(metric_utils, 'get_config_file',
|
|
return_value=self.config_file), \
|
|
mock.patch.object(prometheus_client.PrometheusAPIClient,
|
|
"__init__", return_value=None) as m:
|
|
metric_utils.get_prometheus_client()
|
|
m.assert_called_with("env_overide:1234")
|
|
|
|
def test_get_prometheus_client_no_config_file(self):
|
|
patched_env = {'PROMETHEUS_HOST': 'env_overide',
|
|
'PROMETHEUS_PORT': 'env_port'}
|
|
with mock.patch.dict(os.environ, patched_env), \
|
|
mock.patch.object(metric_utils, 'get_config_file',
|
|
return_value=None), \
|
|
mock.patch.object(prometheus_client.PrometheusAPIClient,
|
|
"__init__", return_value=None) as m:
|
|
metric_utils.get_prometheus_client()
|
|
m.assert_called_with("env_overide:env_port")
|
|
|
|
def test_get_prometheus_client_missing_configuration(self):
|
|
with mock.patch.dict(os.environ, {}), \
|
|
mock.patch.object(metric_utils, 'get_config_file',
|
|
return_value=None), \
|
|
mock.patch.object(prometheus_client.PrometheusAPIClient,
|
|
"__init__", return_value=None):
|
|
self.assertRaises(metric_utils.ConfigurationError,
|
|
metric_utils.get_prometheus_client)
|
|
|
|
|
|
class FormatLabelsTest(testtools.TestCase):
|
|
def setUp(self):
|
|
super(FormatLabelsTest, self).setUp()
|
|
|
|
def test_format_labels_with_normal_labels(self):
|
|
input_dict = {"label_key1": "label_value1",
|
|
"label_key2": "label_value2"}
|
|
expected = "label_key1='label_value1', label_key2='label_value2'"
|
|
|
|
ret = metric_utils.format_labels(input_dict)
|
|
self.assertEqual(expected, ret)
|
|
|
|
def test_format_labels_with_quoted_labels(self):
|
|
input_dict = {"label_key1": "'label_value1'",
|
|
"label_key2": "'label_value2'"}
|
|
expected = "label_key1='label_value1', label_key2='label_value2'"
|
|
|
|
ret = metric_utils.format_labels(input_dict)
|
|
self.assertEqual(expected, ret)
|
|
|
|
|
|
class Metrics2ColsTest(testtools.TestCase):
|
|
def setUp(self):
|
|
super(Metrics2ColsTest, self).setUp()
|
|
|
|
def test_metrics2cols(self):
|
|
metric = {
|
|
'value': [
|
|
1234567,
|
|
5
|
|
],
|
|
'metric': {
|
|
'label1': 'value1',
|
|
'label2': 'value2',
|
|
}
|
|
}
|
|
input_metrics = [prometheus_client.PrometheusMetric(metric)]
|
|
expected = (['label1', 'label2', 'value'], [['value1', 'value2', 5]])
|
|
|
|
ret = metric_utils.metrics2cols(input_metrics)
|
|
self.assertEqual(expected, ret)
|