Update patch set 2
Patch Set 2: Code-Review+1 (1 comment) Patch-set: 2 Reviewer: Gerrit User 34429 <34429@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1, c3ee6e0f1945fa0d5d9eac0761e4f108e9c28bb5
This commit is contained in:
parent
170250a9c0
commit
173ea25672
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "98829b96_99a082b4",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 34429
|
||||
},
|
||||
"writtenOn": "2023-09-25T08:05:52Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for this optimization. I read the discussion about this on IRC and it seems the actual problem here is not that octaviaclient sets these values to False, but that users do a pip install without defining the version that matches with the Zed release. Users will still see the new HSTS fields in the client\u0027s help page and will still be able to set these flags and provoke API errors as seen, so this seems to be a workaround only.\n\nSo, I wonder if it\u0027s not better to simply tell users to install the correct version for Zed, ie. to do a `pip install python-octaviaclient\u003c3.3.0`.",
|
||||
"revId": "ef954db9ac29daa91ff9410c9ae657818bc3b3da",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue