openstack
/
python-octaviaclient
Code Issues Proposed changes

Update patch set 12 

Patch Set 12: Code-Review+2

(2 comments)

Patch-set: 12
Reviewer: Gerrit User 11628 <11628@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 18d6a14d2f686a9db317ee3b046d3b0f682ed1a7
This commit is contained in:
Gerrit User 11628 2023-08-22 20:51:14 +00:00 committed by Gerrit Code Review
parent f01c1340e9
commit 23e79f7428
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
15a8d741243ada386dccc901052e71b5e6f1b731 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "efb85db4_a8210929",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 11628
},
"writtenOn": "2023-08-22T20:51:14Z",
"side": 1,
"message": "One comment that can be added in a follow up patch.",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cdc744a7_d2804eaa",
"filename": "octaviaclient/osc/v2/listener.py",
"patchSetId": 12
},
"lineNbr": 215,
"author": {
"id": 11628
},
"writtenOn": "2023-08-22T20:51:14Z",
"side": 1,
"message": "You could update the validate method to check that someone isn\u0027t trying to specify the optional parameters when they do not provide hsts-max-age.\nhttps://github.com/openstack/python-octaviaclient/blob/master/octaviaclient/osc/v2/validate.py#L59",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}