openstack/python-octaviaclient
Code Issues Proposed changes

Merge "Fixed --wait flag with l7rule create"

Browse Source
This commit is contained in:
Zuul
2025-08-27 12:19:18 +00:00
committed by Gerrit Code Review
parent d63efb3654 05f0aac118
commit c4dd1e1e37
3 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
octaviaclient/osc/v2/l7rule.py
View File

@@ -127,7 +127,7 @@ class CreateL7Rule(command.ShowOne):
data = { data = {
'rule': ( 'rule': (
self.app.client_manager.load_balancer.l7rule_show( self.app.client_manager.load_balancer.l7rule_show(
l7policy_id, data['rule']['id'])) data['rule']['id'], l7policy_id))
} }
formatters = {'tags': v2_utils.FlatListColumn} formatters = {'tags': v2_utils.FlatListColumn}

2
octaviaclient/tests/unit/osc/v2/test_l7rule.py
View File

@@ -267,6 +267,8 @@ class TestL7RuleCreate(TestL7Rule):
sleep_time=mock.ANY, sleep_time=mock.ANY,
status_field='provisioning_status') status_field='provisioning_status')
self.api_mock.l7rule_show.assert_called_with(mock.ANY, self._l7po.id)
@mock.patch('octaviaclient.osc.v2.utils.get_l7rule_attrs') @mock.patch('octaviaclient.osc.v2.utils.get_l7rule_attrs')
def test_l7rule_create_with_tag(self, mock_attrs): def test_l7rule_create_with_tag(self, mock_attrs):
mock_attrs.return_value = { mock_attrs.return_value = {

5
releasenotes/notes/fix-l7rule-create-wait-1f087c17a82eedeb.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
fixes:
- |
Fixed a bug when using the ``--wait`` flag with the ``l7rule create``
command, it displayed an error message even when the command succeeded.