python-octaviaclient/15a8d741243ada386dccc901052...

90 lines
2.6 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "efb85db4_a8210929",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 11628
},
"writtenOn": "2023-08-22T20:51:14Z",
"side": 1,
"message": "One comment that can be added in a follow up patch.",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "60de7714_683686a8",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 29244
},
"writtenOn": "2023-08-23T13:13:54Z",
"side": 1,
"message": "W-1 until the feature is merged in Octavia",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "240a94d9_70c48144",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 29244
},
"writtenOn": "2023-08-24T06:29:20Z",
"side": 1,
"message": "Feature patch merged",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cdc744a7_d2804eaa",
"filename": "octaviaclient/osc/v2/listener.py",
"patchSetId": 12
},
"lineNbr": 215,
"author": {
"id": 11628
},
"writtenOn": "2023-08-22T20:51:14Z",
"side": 1,
"message": "You could update the validate method to check that someone isn\u0027t trying to specify the optional parameters when they do not provide hsts-max-age.\nhttps://github.com/openstack/python-octaviaclient/blob/master/octaviaclient/osc/v2/validate.py#L59",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "67501f9e_85119399",
"filename": "octaviaclient/osc/v2/listener.py",
"patchSetId": 12
},
"lineNbr": 215,
"author": {
"id": 34429
},
"writtenOn": "2023-08-23T11:51:54Z",
"side": 1,
"message": "Done in follow up patch in patch chain.",
"parentUuid": "cdc744a7_d2804eaa",
"revId": "15a8d741243ada386dccc901052e71b5e6f1b731",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}