From 060d706bf4219523b2f4a6245a3b6a5a43743453 Mon Sep 17 00:00:00 2001 From: ArtofBugs Date: Tue, 28 Jan 2025 09:10:22 -0800 Subject: [PATCH] Identity: Deprecate `--region None` in limits/registered limits Change-Id: I37afac1185595216e868202c861d3de719b32073 --- openstackclient/identity/v3/limit.py | 15 +++++++++++++++ .../identity/v3/registered_limit.py | 18 ++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/openstackclient/identity/v3/limit.py b/openstackclient/identity/v3/limit.py index 59cc1398c2..44a3f63569 100644 --- a/openstackclient/identity/v3/limit.py +++ b/openstackclient/identity/v3/limit.py @@ -90,6 +90,13 @@ class CreateLimit(command.ShowOne): region = common_utils.get_resource( identity_client.regions, parsed_args.region ) + else: + self.log.warning( + _( + "Passing 'None' to indicate no region is deprecated. " + "Instead, don't pass --region." + ) + ) limit = identity_client.limits.create( project, @@ -158,6 +165,14 @@ class ListLimit(command.Lister): region = common_utils.get_resource( identity_client.regions, parsed_args.region ) + else: + self.log.warning( + _( + "Passing 'None' to indicate no region is deprecated. " + "Instead, don't pass --region." + ) + ) + project = None if parsed_args.project: project = utils.find_resource( diff --git a/openstackclient/identity/v3/registered_limit.py b/openstackclient/identity/v3/registered_limit.py index f71ef1f5a3..336151ddbf 100644 --- a/openstackclient/identity/v3/registered_limit.py +++ b/openstackclient/identity/v3/registered_limit.py @@ -81,6 +81,13 @@ class CreateRegisteredLimit(command.ShowOne): region = common_utils.get_resource( identity_client.regions, parsed_args.region ) + else: + self.log.warning( + _( + "Passing 'None' to indicate no region is deprecated. " + "Instead, don't pass --region." + ) + ) registered_limit = identity_client.registered_limits.create( service, @@ -182,6 +189,13 @@ class ListRegisteredLimit(command.Lister): region = common_utils.get_resource( identity_client.regions, parsed_args.region ) + else: + self.log.warning( + _( + "Passing 'None' to indicate no region is deprecated. " + "Instead, don't pass --region." + ) + ) registered_limits = identity_client.registered_limits.list( service=service, @@ -280,6 +294,10 @@ class SetRegisteredLimit(command.ShowOne): region = common_utils.get_resource( identity_client.regions, parsed_args.region ) + else: + self.log.warning( + _("Passing 'None' to indicate no region is deprecated.") + ) registered_limit = identity_client.registered_limits.update( parsed_args.registered_limit_id,