openstack/python-openstackclient
Code Issues Proposed changes

Don't warn about unsupported version with SDK-based commands

Browse Source 
This doesn't make sense: SDK (and the server) will handle this for us.

Change-Id: I31b84e09eca0dc2bc5316d6727620346ae519512
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-bug: #2106760
This commit is contained in:
Stephen Finucane
2025-04-10 18:21:15 +01:00
parent 7ecdb69f08
commit 11495e655a
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
openstackclient/compute/client.py
View File

@@ -46,3 +46,8 @@ def build_option_parser(parser):
% DEFAULT_API_VERSION, % DEFAULT_API_VERSION,
) )
return parser return parser
def check_api_version(check_version):
# SDK supports auto-negotiation for us: always return True
return True

5
openstackclient/image/client.py
View File

@@ -46,3 +46,8 @@ def build_option_parser(parser):
% DEFAULT_API_VERSION, % DEFAULT_API_VERSION,
) )
return parser return parser
def check_api_version(check_version):
# SDK supports auto-negotiation for us: always return True
return True

6
openstackclient/network/client.py
View File

@@ -27,12 +27,6 @@ API_VERSIONS = ('2.0', '2')
def make_client(instance): def make_client(instance):
"""Returns a network proxy""" """Returns a network proxy"""
# NOTE(dtroyer): As of osc-lib 1.8.0 and OpenStackSDK 0.10.0 the
# old Profile interface and separate client creation
# for each API that uses the SDK is unnecessary. This
# callback remains as a remnant of the original plugin
# interface and to avoid the code churn of changing all
# of the existing references.
LOG.debug( LOG.debug(
'Network client initialized using OpenStack SDK: %s', 'Network client initialized using OpenStack SDK: %s',
instance.sdk_connection.network, instance.sdk_connection.network,