openstack
/
python-openstackclient
Code Issues Proposed changes

Use instanceof instead of type 

Adjusted conditional statements to use instanceof when
comparing variables. Instanceof supports inheritance type
checking better than type.

Change-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c
Closes-Bug: 1548530
This commit is contained in:
Brandon Palm 2016-02-22 16:20:30 -06:00
parent c57fc41c33
commit 11a8f911af
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
openstackclient/api/api.py
View File

@ -243,14 +243,14 @@ class BaseAPI(KeystoneSession):
def getlist(kw):
"""Do list call, unwrap resource dict if present"""
ret = self.list(path, **kw)
if type(ret) == dict and resource in ret:
if isinstance(ret, dict) and resource in ret:
ret = ret[resource]
return ret
# Search by attribute
kwargs = {attr: value}
data = getlist(kwargs)
if type(data) == dict:
if isinstance(data, dict):
return data
if len(data) == 1:
return data[0]
@ -283,7 +283,7 @@ class BaseAPI(KeystoneSession):
"""
items = self.list(path)
if type(items) == dict:
if isinstance(items, dict):
# strip off the enclosing dict
key = list(items.keys())[0]
items = items[key]

2
openstackclient/api/utils.py
View File

@ -61,7 +61,7 @@ def simple_filter(
# Searching data fields
search_value = d[attr]
elif (property_field and property_field in d and
type(d[property_field]) is dict):
isinstance(d[property_field], dict)):
# Searching a properties field - do this separately because
# we don't want to fail over to checking the fields if a
# property name is given.

4
openstackclient/tests/test_shell.py
View File

@ -317,7 +317,7 @@ class TestShellOptions(TestShell):
if not test_opts[opt][1]:
continue
key = opt2attr(opt)
if type(test_opts[opt][0]) is str:
if isinstance(test_opts[opt][0], str):
cmd = opt + " " + test_opts[opt][0]
else:
cmd = opt
@ -331,7 +331,7 @@ class TestShellOptions(TestShell):
if not test_opts[opt][1]:
continue
key = opt2attr(opt)
if type(test_opts[opt][0]) is str:
if isinstance(test_opts[opt][0], str):
cmd = opt + " " + test_opts[opt][0]
else:
cmd = opt