openstack/python-openstackclient
Code Issues Proposed changes

Merge "Fix: extend in-use volumes check"

Browse Source
This commit is contained in:
Zuul 2025-04-03 16:40:17 +00:00 committed by Gerrit Code Review
commit 1e8d243986
1 changed files with 11 additions and 5 deletions

16
openstackclient/volume/v3/volume.py

@ -764,18 +764,24 @@ class SetVolume(command.Command):
_("New size must be greater than %s GB") % volume.size
)
raise exceptions.CommandError(msg)
if (
volume.status != 'available'
and not volume_client.api_version.matches('3.42')
):
if volume.status not in ('available', 'in-use'):
msg = (
_(
"Volume is in %s state, it must be available "
"before size can be extended"
"or in-use before size can be extended."
)
% volume.status
)
raise exceptions.CommandError(msg)
if (
volume.status == 'in-use'
and not volume_client.api_version.matches('3.42')
):
msg = _(
"--os-volume-api-version 3.42 or greater is "
"required to extend in-use volumes."
)
raise exceptions.CommandError(msg)
volume_client.volumes.extend(volume.id, parsed_args.size)
except Exception as e:
LOG.error(_("Failed to set volume size: %s"), e)