openstack/python-openstackclient
Code Issues Proposed changes

Python 3: remove a useless code to safe_encode()

Browse Source 
The safe_encode method returns bytes, so we cannot concatenate its output with
text strings. This call does not seem needed after all, so let's just remove
it.

Change-Id: I6c18427559147d4c732ff7daa6d6006e7e5f6365
This commit is contained in:
Cyril Roelandt
2014-07-04 10:20:37 +02:00
parent 7f59fa5943
commit 1fedd38de6
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/common/utils.py
View File

@@ -23,7 +23,6 @@ import sys
import time import time
from openstackclient.common import exceptions from openstackclient.common import exceptions
from openstackclient.openstack.common import strutils
def find_resource(manager, name_or_id): def find_resource(manager, name_or_id):
@@ -79,8 +78,7 @@ def format_dict(data):
output = "" output = ""
for s in data: for s in data:
output = output + s + "='" + \ output = output + s + "='" + six.text_type(data[s]) + "', "
strutils.safe_encode(six.text_type(data[s])) + "', "
return output[:-2] return output[:-2]