openstack/python-openstackclient
Code Issues Proposed changes

Merge "Use assertIsNone() instead of assertEqual(None, xxx)"

Browse Source
This commit is contained in:
Jenkins
2016-02-19 16:13:40 +00:00
committed by Gerrit Code Review
parent 61d9604f8a ef64a8b47d
commit 20f86465af
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/tests/network/v2/test_security_group.py
View File

@@ -61,7 +61,7 @@ class TestDeleteSecurityGroupNetwork(TestSecurityGroup):
self.network.delete_security_group.assert_called_with( self.network.delete_security_group.assert_called_with(
self._security_group) self._security_group)
self.assertEqual(None, result) self.assertIsNone(result)
class TestDeleteSecurityGroupCompute(TestSecurityGroup): class TestDeleteSecurityGroupCompute(TestSecurityGroup):
@@ -96,4 +96,4 @@ class TestDeleteSecurityGroupCompute(TestSecurityGroup):
self.compute.security_groups.delete.assert_called_with( self.compute.security_groups.delete.assert_called_with(
self._security_group.id) self._security_group.id)
self.assertEqual(None, result) self.assertIsNone(result)

4
openstackclient/tests/network/v2/test_security_group_rule.py
View File

@@ -67,7 +67,7 @@ class TestDeleteSecurityGroupRuleNetwork(TestSecurityGroupRuleNetwork):
self.network.delete_security_group_rule.assert_called_with( self.network.delete_security_group_rule.assert_called_with(
self._security_group_rule) self._security_group_rule)
self.assertEqual(None, result) self.assertIsNone(result)
class TestDeleteSecurityGroupRuleCompute(TestSecurityGroupRuleCompute): class TestDeleteSecurityGroupRuleCompute(TestSecurityGroupRuleCompute):
@@ -97,4 +97,4 @@ class TestDeleteSecurityGroupRuleCompute(TestSecurityGroupRuleCompute):
self.compute.security_group_rules.delete.assert_called_with( self.compute.security_group_rules.delete.assert_called_with(
self._security_group_rule.id) self._security_group_rule.id)
self.assertEqual(None, result) self.assertIsNone(result)

6
openstackclient/tests/object/v1/test_container.py
View File

@@ -67,7 +67,7 @@ class TestContainerDelete(TestContainer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.assertEqual(None, self.cmd.take_action(parsed_args)) self.assertIsNone(self.cmd.take_action(parsed_args))
kwargs = {} kwargs = {}
c_mock.assert_called_with( c_mock.assert_called_with(
@@ -92,7 +92,7 @@ class TestContainerDelete(TestContainer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.assertEqual(None, self.cmd.take_action(parsed_args)) self.assertIsNone(self.cmd.take_action(parsed_args))
kwargs = {} kwargs = {}
c_mock.assert_called_with( c_mock.assert_called_with(
@@ -120,7 +120,7 @@ class TestContainerDelete(TestContainer):
] ]
parsed_args = self.check_parser(self.cmd, arglist, verifylist) parsed_args = self.check_parser(self.cmd, arglist, verifylist)
self.assertEqual(None, self.cmd.take_action(parsed_args)) self.assertIsNone(self.cmd.take_action(parsed_args))
kwargs = {} kwargs = {}
c_mock.assert_called_with( c_mock.assert_called_with(