openstack/python-openstackclient
Code Issues Proposed changes

Removed the emit_duplicated_warning() funtion.

Browse Source 
Since this function is called once, I moved its implementaion to where
its called.

Story: 2010344

Change-Id: Iaf06def1a06ffbb605ee42569e6f87b409a72772
This commit is contained in:
Mohammed Al-Dokimi 2024-09-02 16:55:48 +02:00 committed by Stephen Finucane
parent c2d96c5938
commit 2bf123f315
1 changed files with 9 additions and 12 deletions

21
openstackclient/compute/v2/server.py

@ -1520,17 +1520,6 @@ class CreateServer(command.ShowOne):
if not image and parsed_args.image_properties:
def emit_duplicated_warning(img):
img_uuid_list = [str(image.id) for image in img]
LOG.warning(
'Multiple matching images: %(img_uuid_list)s\n'
'Using image: %(chosen_one)s',
{
'img_uuid_list': img_uuid_list,
'chosen_one': img_uuid_list[0],
},
)
def _match_image(image_api, wanted_properties):
image_list = image_api.images()
images_matched = []
@ -1568,7 +1557,15 @@ class CreateServer(command.ShowOne):
images = _match_image(image_client, parsed_args.image_properties)
if len(images) > 1:
emit_duplicated_warning(images, parsed_args.image_properties)
img_uuid_list = [str(image.id) for image in images]
LOG.warning(
'Multiple matching images: %(img_uuid_list)s\n'
'Using image: %(chosen_one)s',
{
'img_uuid_list': img_uuid_list,
'chosen_one': img_uuid_list[0],
},
)
if images:
image = images[0]
else: