Browse Source

Add "--property" option to "snapshot create" command in volumev2

Add "--property" option to "snapshot create" command
in volumev2 (v2 only) to support adding properties to
a new snapshot.

Change-Id: Ie0e90c9ccc2ac89b3b7b0ac89751fd864aada9a4
Closes-Bug: #1597192
tags/3.0.0
Huanxuan Ao 3 years ago
parent
commit
3222ffc157
4 changed files with 27 additions and 3 deletions
  1. +7
    -0
      doc/source/command-objects/snapshot.rst
  2. +7
    -2
      openstackclient/tests/volume/v2/test_snapshot.py
  3. +9
    -1
      openstackclient/volume/v2/snapshot.py
  4. +4
    -0
      releasenotes/notes/bug-1597192-52801f7520287309.yaml

+ 7
- 0
doc/source/command-objects/snapshot.rst View File

@@ -16,6 +16,7 @@ Create new snapshot
[--name <name>]
[--description <description>]
[--force]
[--property <key=value> [...] ]
<volume>

.. option:: --name <name>
@@ -30,6 +31,12 @@ Create new snapshot

Create a snapshot attached to an instance. Default is False

.. option:: --property <key=value>

Set a property to this snapshot (repeat option to set multiple properties)

*Volume version 2 only*

.. _snapshot_create-snapshot:
.. describe:: <volume>


+ 7
- 2
openstackclient/tests/volume/v2/test_snapshot.py View File

@@ -70,12 +70,15 @@ class TestSnapshotCreate(TestSnapshot):
"--name", self.new_snapshot.name,
"--description", self.new_snapshot.description,
"--force",
'--property', 'Alpha=a',
'--property', 'Beta=b',
self.new_snapshot.volume_id,
]
verifylist = [
("name", self.new_snapshot.name),
("description", self.new_snapshot.description),
("force", True),
('property', {'Alpha': 'a', 'Beta': 'b'}),
("volume", self.new_snapshot.volume_id),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@@ -86,7 +89,8 @@ class TestSnapshotCreate(TestSnapshot):
self.new_snapshot.volume_id,
force=True,
name=self.new_snapshot.name,
description=self.new_snapshot.description
description=self.new_snapshot.description,
metadata={'Alpha': 'a', 'Beta': 'b'},
)
self.assertEqual(self.columns, columns)
self.assertEqual(self.data, data)
@@ -110,7 +114,8 @@ class TestSnapshotCreate(TestSnapshot):
self.new_snapshot.volume_id,
force=True,
name=None,
description=self.new_snapshot.description
description=self.new_snapshot.description,
metadata=None,
)
self.assertEqual(self.columns, columns)
self.assertEqual(self.data, data)

+ 9
- 1
openstackclient/volume/v2/snapshot.py View File

@@ -51,6 +51,13 @@ class CreateSnapshot(command.ShowOne):
help=_("Create a snapshot attached to an instance. "
"Default is False")
)
parser.add_argument(
"--property",
metavar="<key=value>",
action=parseractions.KeyValueAction,
help=_("Set a property to this snapshot "
"(repeat option to set multiple properties)"),
)
return parser

def take_action(self, parsed_args):
@@ -61,7 +68,8 @@ class CreateSnapshot(command.ShowOne):
volume_id,
force=parsed_args.force,
name=parsed_args.name,
description=parsed_args.description
description=parsed_args.description,
metadata=parsed_args.property,
)
snapshot._info.update(
{'properties': utils.format_dict(snapshot._info.pop('metadata'))}

+ 4
- 0
releasenotes/notes/bug-1597192-52801f7520287309.yaml View File

@@ -0,0 +1,4 @@
---
features:
- Add ``--property`` option to ``snapshot create`` command.
[Bug `1597192 <https://bugs.launchpad.net/bugs/1597192>`_]

Loading…
Cancel
Save