openstack
/
python-openstackclient
Code Issues Proposed changes

Replace assertItemsEqual with assertCountEqual 

Similar to [1] required after adding some new tests in [2]

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/805790
[2] https://review.opendev.org/c/openstack/python-openstackclient/+/819938

Change-Id: I6f4f867048793f9e1e1a05afa4f2beaf8def5053
This commit is contained in:
Alfredo Moralejo 2023-01-31 16:56:33 +01:00
parent e1872e01bf
commit 42d9b6ea57
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
openstackclient/tests/unit/compute/v2/test_server.py
View File

@ -4404,8 +4404,8 @@ class TestServerListV273(_TestServerList):
self.search_opts['locked'] = True
self.servers_mock.list.assert_called_with(**self.kwargs)
self.assertItemsEqual(self.columns, columns)
self.assertItemsEqual(self.data, tuple(data))
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, tuple(data))
def test_server_list_with_unlocked_v273(self):
@ -4424,8 +4424,8 @@ class TestServerListV273(_TestServerList):
self.search_opts['locked'] = False
self.servers_mock.list.assert_called_with(**self.kwargs)
self.assertItemsEqual(self.columns, columns)
self.assertItemsEqual(self.data, tuple(data))
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, tuple(data))
def test_server_list_with_locked_and_unlocked(self):
@ -4465,8 +4465,8 @@ class TestServerListV273(_TestServerList):
self.servers_mock.list.assert_called_with(**self.kwargs)
self.assertItemsEqual(self.columns, columns)
self.assertItemsEqual(self.data, tuple(data))
self.assertCountEqual(self.columns, columns)
self.assertCountEqual(self.data, tuple(data))
@mock.patch.object(iso8601, 'parse_date', side_effect=iso8601.ParseError)
def test_server_list_with_invalid_changes_before(