openstack/python-openstackclient
Code Issues Proposed changes

Merge "Allow users to list all images"

Browse Source
This commit is contained in:
Zuul 2022-06-20 15:19:59 +00:00 committed by Gerrit Code Review
commit 4f79def9aa
2 changed files with 41 additions and 0 deletions
openstackclient
image/v2
image.py
tests/unit/image/v2
test_image.py

9
openstackclient/image/v2/image.py

@ -575,6 +575,13 @@ class ListImage(command.Lister):
default=False,
help=_("List only shared images"),
)
public_group.add_argument(
"--all",
dest="all",
action="store_true",
default=False,
help=_("List all images"),
)
parser.add_argument(
'--property',
metavar='<key=value>',
@ -675,6 +682,8 @@ class ListImage(command.Lister):
kwargs['visibility'] = 'community'
if parsed_args.shared:
kwargs['visibility'] = 'shared'
if parsed_args.all:
kwargs['visibility'] = 'all'
if parsed_args.limit:
kwargs['limit'] = parsed_args.limit
if parsed_args.marker:

32
openstackclient/tests/unit/image/v2/test_image.py

@ -486,6 +486,7 @@ class TestImageList(TestImage):
('private', False),
('community', False),
('shared', False),
('all', False),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@ -510,6 +511,7 @@ class TestImageList(TestImage):
('private', False),
('community', False),
('shared', False),
('all', False),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@ -534,6 +536,7 @@ class TestImageList(TestImage):
('private', True),
('community', False),
('shared', False),
('all', False),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@ -558,6 +561,7 @@ class TestImageList(TestImage):
('private', False),
('community', True),
('shared', False),
('all', False),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@ -582,6 +586,7 @@ class TestImageList(TestImage):
('private', False),
('community', False),
('shared', True),
('all', False),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@ -597,6 +602,31 @@ class TestImageList(TestImage):
self.assertEqual(self.columns, columns)
self.assertCountEqual(self.datalist, tuple(data))
def test_image_list_all_option(self):
arglist = [
'--all',
]
verifylist = [
('public', False),
('private', False),
('community', False),
('shared', False),
('all', True),
('long', False),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
# In base command class Lister in cliff, abstract method take_action()
# returns a tuple containing the column names and an iterable
# containing the data to be listed.
columns, data = self.cmd.take_action(parsed_args)
self.client.images.assert_called_with(
visibility='all',
)
self.assertEqual(self.columns, columns)
self.assertCountEqual(self.datalist, tuple(data))
def test_image_list_shared_member_status_option(self):
arglist = [
'--shared',
@ -607,6 +637,7 @@ class TestImageList(TestImage):
('private', False),
('community', False),
('shared', True),
('all', False),
('long', False),
('member_status', 'all')
]
@ -634,6 +665,7 @@ class TestImageList(TestImage):
('private', False),
('community', False),
('shared', True),
('all', False),
('long', False),
('member_status', 'all')
]