openstack/python-openstackclient
Code Issues Proposed changes

Merge "Add callback on plugin load failure"

Browse Source
This commit is contained in:
Zuul 2024-08-14 11:12:03 +00:00 committed by Gerrit Code Review
commit 50d1e0916b
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
openstackclient/common/clientmanager.py
View File

@ -158,10 +158,22 @@ class ClientManager(clientmanager.ClientManager):
# Plugin Support # Plugin Support
def _on_load_failure_callback(
manager: stevedore.ExtensionManager,
ep: importlib.metadata.EntryPoint,
err: Exception,
) -> None:
sys.stderr.write(
f"WARNING: Failed to import plugin {ep.group}:{ep.name}: {err}.\n"
)
def get_plugin_modules(group): def get_plugin_modules(group):
"""Find plugin entry points""" """Find plugin entry points"""
mod_list = [] mod_list = []
mgr = stevedore.ExtensionManager(group) mgr = stevedore.ExtensionManager(
group, on_load_failure_callback=_on_load_failure_callback
)
for ep in mgr: for ep in mgr:
LOG.debug('Found plugin %s', ep.name) LOG.debug('Found plugin %s', ep.name)
@ -180,9 +192,8 @@ def get_plugin_modules(group):
module = importlib.import_module(module_name) module = importlib.import_module(module_name)
except Exception as err: except Exception as err:
sys.stderr.write( sys.stderr.write(
"WARNING: Failed to import plugin {}: {}.\n".format( f"WARNING: Failed to import plugin {ep.group}:{ep.name}: "
ep.name, err f"{err}.\n"
)
) )
continue continue