openstack/python-openstackclient
Code Issues Proposed changes

Merge "compute: Remove unnecessary try-except"

Browse Source
This commit is contained in:
Zuul
2024-07-01 22:38:55 +00:00
committed by Gerrit Code Review
parent ca81b1acf0 40ce56201c
commit 518420abe4
1 changed files with 12 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
openstackclient/compute/v2/server.py
View File

@@ -4844,17 +4844,12 @@ class StartServer(command.Command):
def take_action(self, parsed_args): def take_action(self, parsed_args):
compute_client = self.app.client_manager.sdk_connection.compute compute_client = self.app.client_manager.sdk_connection.compute
for server in parsed_args.server: for server in parsed_args.server:
try: server_id = compute_client.find_server(
server_id = compute_client.find_server( server,
server, ignore_missing=False,
ignore_missing=False, details=False,
details=False, all_projects=parsed_args.all_projects,
all_projects=parsed_args.all_projects, ).id
).id
except sdk_exceptions.HttpException as exc:
if exc.status_code == 403:
msg = _("Policy doesn't allow passing all-projects")
raise exceptions.Forbidden(msg)
compute_client.start_server(server_id) compute_client.start_server(server_id)
@@ -4884,18 +4879,12 @@ class StopServer(command.Command):
def take_action(self, parsed_args): def take_action(self, parsed_args):
compute_client = self.app.client_manager.sdk_connection.compute compute_client = self.app.client_manager.sdk_connection.compute
for server in parsed_args.server: for server in parsed_args.server:
try: server_id = compute_client.find_server(
server_id = compute_client.find_server( server,
server, ignore_missing=False,
ignore_missing=False, details=False,
details=False, all_projects=parsed_args.all_projects,
all_projects=parsed_args.all_projects, ).id
).id
except sdk_exceptions.HttpException as exc:
if exc.status_code == 403:
msg = _("Policy doesn't allow passing all-projects")
raise exceptions.Forbidden(msg)
compute_client.stop_server(server_id) compute_client.stop_server(server_id)