From 51ecb5f98486a38b535a3664f0957c30eec27abf Mon Sep 17 00:00:00 2001 From: Doug Goldstein Date: Tue, 15 Jul 2025 13:20:44 -0500 Subject: [PATCH] volume: fix volume service set call The command line operation could never work due to the incorrect call of the openstacksdk API. This is updated to make it work and report errors back to the user. Closes-Bug: #2116969 Change-Id: I87cc410853c03b00dd1549d67cb1b9a8145bcfaa Signed-off-by: Doug Goldstein --- openstackclient/volume/v2/service.py | 2 +- openstackclient/volume/v3/service.py | 2 +- .../notes/volume-service-set-fix-345a8bc84267f743.yaml | 5 +++++ 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml diff --git a/openstackclient/volume/v2/service.py b/openstackclient/volume/v2/service.py index 418ecec427..48cdba721e 100644 --- a/openstackclient/volume/v2/service.py +++ b/openstackclient/volume/v2/service.py @@ -126,7 +126,7 @@ class SetService(command.Command): volume_client = self.app.client_manager.sdk_connection.volume service = volume_client.find_service( - host=parsed_args.host, service=parsed_args.service + parsed_args.service, ignore_missing=False, host=parsed_args.host ) if parsed_args.enable: diff --git a/openstackclient/volume/v3/service.py b/openstackclient/volume/v3/service.py index fb41b1f472..0f14e472c8 100644 --- a/openstackclient/volume/v3/service.py +++ b/openstackclient/volume/v3/service.py @@ -133,7 +133,7 @@ class SetService(command.Command): volume_client = self.app.client_manager.sdk_connection.volume service = volume_client.find_service( - host=parsed_args.host, service=parsed_args.service + parsed_args.service, ignore_missing=False, host=parsed_args.host ) if parsed_args.enable: diff --git a/releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml b/releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml new file mode 100644 index 0000000000..e21e12dbbc --- /dev/null +++ b/releasenotes/notes/volume-service-set-fix-345a8bc84267f743.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + The 'volume service set' command could not work due to a bad API call. + [Bug `2116969 `_]