openstack
/
python-openstackclient
Code Issues Proposed changes

Remove log translations 

Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

Change-Id: I504de69b2e64250740ebcab432042a16f966fdbe
Closes-Bug: #1674584
This commit is contained in:
yfzhao 2017-03-21 14:40:28 +08:00
parent 6329c04297
commit 535def3447
2 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
openstackclient/compute/v2/service.py
View File

@ -22,7 +22,6 @@ from osc_lib import exceptions
from osc_lib import utils from osc_lib import utils
from openstackclient.i18n import _ from openstackclient.i18n import _
from openstackclient.i18n import _LE
LOG = logging.getLogger(__name__) LOG = logging.getLogger(__name__)
@ -189,7 +188,7 @@ class SetService(command.Command):
cs.disable(parsed_args.host, parsed_args.service) cs.disable(parsed_args.host, parsed_args.service)
except Exception: except Exception:
status = "enabled" if enabled else "disabled" status = "enabled" if enabled else "disabled"
LOG.error(_LE("Failed to set service status to %s"), status) LOG.error("Failed to set service status to %s", status)
result += 1 result += 1
force_down = None force_down = None
@ -203,7 +202,7 @@ class SetService(command.Command):
force_down=force_down) force_down=force_down)
except Exception: except Exception:
state = "down" if force_down else "up" state = "down" if force_down else "up"
LOG.error(_LE("Failed to set service state to %s"), state) LOG.error("Failed to set service state to %s", state)
result += 1 result += 1
if result > 0: if result > 0:

10
openstackclient/i18n.py
View File

@ -19,13 +19,3 @@ _translators = oslo_i18n.TranslatorFactory(domain='openstackclient')
# The primary translation function using the well-known name "_" # The primary translation function using the well-known name "_"
_ = _translators.primary _ = _translators.primary
# Translators for log levels.
#
# The abbreviated names are meant to reflect the usual use of a short
# name like '_'. The "L" is for "log" and the other letter comes from
# the level.
_LI = _translators.log_info
_LW = _translators.log_warning
_LE = _translators.log_error
_LC = _translators.log_critical