From 61ad83b57580c76a1c448e03064c4df6bcc01e87 Mon Sep 17 00:00:00 2001
From: Pierre Prinetti <pierreprinetti@redhat.com>
Date: Thu, 3 Oct 2019 15:53:39 +0200
Subject: [PATCH] versions: Fix 'versions show' help message
The command `openstack versions show --help` shows a copy-paste nit.
Change-Id: I9e4e86429ffd630c566bbdf2929e7995c9b0dbe1
Signed-off-by: Pierre Prinetti <pierreprinetti@redhat.com>
---
doc/source/cli/command-objects/versions.rst | 12 +++++++++++-
openstackclient/common/versions.py | 4 ++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/doc/source/cli/command-objects/versions.rst b/doc/source/cli/command-objects/versions.rst
index 6742565265..0aa9a1b785 100644
--- a/doc/source/cli/command-objects/versions.rst
+++ b/doc/source/cli/command-objects/versions.rst
@@ -17,6 +17,7 @@ Show service versions:
[--interface <interface>]
[--region-name <region-name>]
[--service <service>]
+ [--status <status>]
.. option:: --all-interfaces
@@ -30,7 +31,7 @@ Show service versions:
.. option:: --region-name <region-name>
- Limit results to only those from region-name
+ Limit results to only those from a given region.
.. option:: --service <service>
@@ -38,4 +39,13 @@ Show service versions:
an exact match to what is in the catalog or a known official value or
alias from `service-types-authority`_.
+.. option:: --status <status>
+
+ Limit results to only those in the given state. Valid values are:
+
+ - SUPPORTED
+ - CURRENT
+ - DEPRECATED
+ - EXPERIMENTAL
+
.. _service-types-authority: https://service-types.openstack.org/
diff --git a/openstackclient/common/versions.py b/openstackclient/common/versions.py
index 3c267bfe0a..e6781bc66f 100644
--- a/openstackclient/common/versions.py
+++ b/openstackclient/common/versions.py
@@ -45,12 +45,12 @@ class ShowVersions(command.Lister):
)
parser.add_argument(
'--service',
- metavar='<region_name>',
+ metavar='<service>',
help=_('Show versions for a specific service.'),
)
parser.add_argument(
'--status',
- metavar='<region_name>',
+ metavar='<status>',
help=_('Show versions for a specific status.'
' [Valid values are SUPPORTED, CURRENT,'
' DEPRECATED, EXPERIMENTAL]'),