openstack/python-openstackclient
Code Issues Proposed changes

Merge "Sort list images by name by default"

Browse Source
This commit is contained in:
Jenkins 2016-12-02 18:50:17 +00:00 committed by Gerrit Code Review
commit 7078502ea6
4 changed files with 11 additions and 3 deletions
doc/source/command-objects
image.rst
openstackclient/image
v1
image.py
v2
image.py
releasenotes/notes
bug-1639231-21823768bd54170a.yaml

2
doc/source/command-objects/image.rst

@ -222,7 +222,7 @@ List available images
.. option:: --sort <key>[:<direction>] .. option:: --sort <key>[:<direction>]
Sort output by selected keys and directions(asc or desc) (default: asc), Sort output by selected keys and directions(asc or desc) (default: name:asc),
multiple keys and directions can be specified separated by comma multiple keys and directions can be specified separated by comma
.. option:: --limit <limit> .. option:: --limit <limit>

3
openstackclient/image/v1/image.py

@ -353,8 +353,9 @@ class ListImage(command.Lister):
parser.add_argument( parser.add_argument(
'--sort', '--sort',
metavar="<key>[:<direction>]", metavar="<key>[:<direction>]",
default='name:asc',
help=_("Sort output by selected keys and directions(asc or desc) " help=_("Sort output by selected keys and directions(asc or desc) "
"(default: asc), multiple keys and directions can be " "(default: name:asc), multiple keys and directions can be "
"specified separated by comma"), "specified separated by comma"),
) )
return parser return parser

3
openstackclient/image/v2/image.py

@ -450,8 +450,9 @@ class ListImage(command.Lister):
parser.add_argument( parser.add_argument(
'--sort', '--sort',
metavar="<key>[:<direction>]", metavar="<key>[:<direction>]",
default='name:asc',
help=_("Sort output by selected keys and directions(asc or desc) " help=_("Sort output by selected keys and directions(asc or desc) "
"(default: asc), multiple keys and directions can be " "(default: name:asc), multiple keys and directions can be "
"specified separated by comma"), "specified separated by comma"),
) )
parser.add_argument( parser.add_argument(

6
releasenotes/notes/bug-1639231-21823768bd54170a.yaml Normal file

@ -0,0 +1,6 @@
---
features:
- |
The ``image list`` command will now sort by name in ascending order by
default. ``--sort`` option will have the default value of ``name:asc``.
[Bug `1639231 <https://bugs.launchpad.net/bugs/1639231>`_]