From 773b869323ffc294170ffbd51bc5b1284cd59fe4 Mon Sep 17 00:00:00 2001 From: Johannes Kulik Date: Tue, 13 Aug 2024 12:14:31 +0200 Subject: [PATCH] compute: Fix --host in server list for new openstacksdk With `openstacksdk` 3.2.0 the `host` attribute of an Instance got added to the `Server` class [0]. With that change, listing servers with the `host` attribute leads to a query-filter for `compute_host` as expected, but `openstacksdk` will also filter for the `host` attribute locally after the results are returned. Since `compute_host` being `OS-EXT-SRV-ATTR:host` is not the same as `host, this means no results are returned. Since we want to keep the old behaviour of filtering by `compute_host` i.e. the service host name, we need to switch to filter for `compute_host`. This is already supported in older versions of `openstacksdk`. [0] https://github.com/openstack/openstacksdk/commit/0f311ff3e2e57bf3659cef77e98551b6c0c7e3c9 Change-Id: I0cd32c5b7d6d4d21194f3efdcfb9b205dea6a91e Closes-bug: #2074200 (cherry picked from commit ffa683ab4edf44219b687af54e2ace5177dbc2f3) --- openstackclient/compute/v2/server.py | 2 +- openstackclient/tests/unit/compute/v2/test_server.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/openstackclient/compute/v2/server.py b/openstackclient/compute/v2/server.py index ec4ec612d7..55aa6469ec 100644 --- a/openstackclient/compute/v2/server.py +++ b/openstackclient/compute/v2/server.py @@ -2648,7 +2648,7 @@ class ListServer(command.Lister): 'status': parsed_args.status, 'flavor': flavor_id, 'image': image_id, - 'host': parsed_args.host, + 'compute_host': parsed_args.host, 'project_id': project_id, 'all_projects': parsed_args.all_projects, 'user_id': user_id, diff --git a/openstackclient/tests/unit/compute/v2/test_server.py b/openstackclient/tests/unit/compute/v2/test_server.py index d33506d0e1..0420bfc17f 100644 --- a/openstackclient/tests/unit/compute/v2/test_server.py +++ b/openstackclient/tests/unit/compute/v2/test_server.py @@ -4581,7 +4581,7 @@ class _TestServerList(TestServer): 'status': None, 'flavor': None, 'image': None, - 'host': None, + 'compute_host': None, 'project_id': None, 'all_projects': False, 'user_id': None,