openstack/python-openstackclient
Code Issues Proposed changes

Use assertItemsEqual() instead of assertListEqual()

Browse Source 
assertListEqual() is order sensitive. So we need to sort
the lists before we compare them. Use assertItemsEqual()
instead is better.

Change-Id: I9eaa98716c7401f5b099b007438acc916dae619b
This commit is contained in:
Tang Chen
2016-03-14 16:22:24 +08:00
parent 76081239d2
commit 7b2e3c7d1c
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
openstackclient/tests/common/test_parseractions.py
View File

@@ -91,11 +91,7 @@ class TestMultiKeyValueAction(utils.TestCase):
{'req1': 'aaa', 'req2': 'bbb'}, {'req1': 'aaa', 'req2': 'bbb'},
{'req1': '', 'req2': ''}, {'req1': '', 'req2': ''},
] ]
# Need to sort the lists before comparing them self.assertItemsEqual(expect, actual)
key = lambda x: x['req1']
expect.sort(key=key)
actual.sort(key=key)
self.assertListEqual(expect, actual)
def test_empty_required_optional(self): def test_empty_required_optional(self):
self.parser.add_argument( self.parser.add_argument(
@@ -119,11 +115,7 @@ class TestMultiKeyValueAction(utils.TestCase):
{'req1': 'aaa', 'req2': 'bbb'}, {'req1': 'aaa', 'req2': 'bbb'},
{'req1': '', 'req2': ''}, {'req1': '', 'req2': ''},
] ]
# Need to sort the lists before comparing them self.assertItemsEqual(expect, actual)
key = lambda x: x['req1']
expect.sort(key=key)
actual.sort(key=key)
self.assertListEqual(expect, actual)
def test_error_values_with_comma(self): def test_error_values_with_comma(self):
self.assertRaises( self.assertRaises(