From c95c73f8e239301b3be7a5264dcb87293cf2dad5 Mon Sep 17 00:00:00 2001 From: Tang Chen Date: Fri, 3 Jun 2016 15:53:49 +0800 Subject: [PATCH] Fix wrong test in flavor unit tests In test_flavor_set_no_project(), we aimed to test a situation like this: User specifies "--project" option, but didn't specifies the project name or ID. But in the source code, it becomes "--project ''". The test could past because if project and property are both None, the command will raise an exception. Change-Id: I39567306debb901e8bad420fa2492f1b207efddc --- openstackclient/tests/compute/v2/test_flavor.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/openstackclient/tests/compute/v2/test_flavor.py b/openstackclient/tests/compute/v2/test_flavor.py index 9d424890ed..434d5f92be 100644 --- a/openstackclient/tests/compute/v2/test_flavor.py +++ b/openstackclient/tests/compute/v2/test_flavor.py @@ -491,17 +491,15 @@ class TestFlavorSet(TestFlavor): def test_flavor_set_no_project(self): arglist = [ - '--project', '', + '--project', self.flavor.id, ] verifylist = [ ('project', ''), ('flavor', self.flavor.id), ] - - parsed_args = self.check_parser(self.cmd, arglist, verifylist) - self.assertRaises(exceptions.CommandError, self.cmd.take_action, - parsed_args) + self.assertRaises(tests_utils.ParserException, self.check_parser, + self.cmd, arglist, verifylist) def test_flavor_set_no_flavor(self): arglist = [