From 8fb19bc2a93c6cf6fa71c809dd47c6123a523b04 Mon Sep 17 00:00:00 2001
From: Kelvin Lui <kelvinlittle@yahoo.com>
Date: Wed, 5 Aug 2015 15:47:08 -0400
Subject: [PATCH] additional functional tests for identity providers

add tests for:

  * delete
  * set
  * list
  * show

Change-Id: Ibe34f28d7ae77d139a6e0edf4fe04215c371c9a8
---
 functional/tests/identity/v3/test_identity.py |  1 +
 functional/tests/identity/v3/test_idp.py      | 34 +++++++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/functional/tests/identity/v3/test_identity.py b/functional/tests/identity/v3/test_identity.py
index bf3da167fa..4c3ff7dab7 100644
--- a/functional/tests/identity/v3/test_identity.py
+++ b/functional/tests/identity/v3/test_identity.py
@@ -43,6 +43,7 @@ class IdentityTests(test.TestCase):
                              'Enabled', 'Interface', 'URL']
 
     IDENTITY_PROVIDER_FIELDS = ['description', 'enabled', 'id', 'remote_ids']
+    IDENTITY_PROVIDER_LIST_HEADERS = ['ID', 'Enabled', 'Description']
 
     @classmethod
     def setUpClass(cls):
diff --git a/functional/tests/identity/v3/test_idp.py b/functional/tests/identity/v3/test_idp.py
index 6a07f158d0..3d6739d7f4 100644
--- a/functional/tests/identity/v3/test_idp.py
+++ b/functional/tests/identity/v3/test_idp.py
@@ -11,6 +11,7 @@
 #    under the License.
 
 from functional.tests.identity.v3 import test_identity
+from tempest_lib.common.utils import data_utils
 
 
 class IdentityProviderTests(test_identity.IdentityTests):
@@ -18,3 +19,36 @@ class IdentityProviderTests(test_identity.IdentityTests):
 
     def test_idp_create(self):
         self._create_dummy_idp()
+
+    def test_idp_delete(self):
+        identity_provider = self._create_dummy_idp(add_clean_up=False)
+        raw_output = self.openstack('identity provider delete %s'
+                                    % identity_provider)
+        self.assertEqual(0, len(raw_output))
+
+    def test_idp_show(self):
+        identity_provider = self._create_dummy_idp(add_clean_up=True)
+        raw_output = self.openstack('identity provider show %s'
+                                    % identity_provider)
+        items = self.parse_show(raw_output)
+        self.assert_show_fields(items, self.IDENTITY_PROVIDER_FIELDS)
+
+    def test_idp_list(self):
+        self._create_dummy_idp(add_clean_up=True)
+        raw_output = self.openstack('identity provider list')
+        items = self.parse_listing(raw_output)
+        self.assert_table_structure(items, self.IDENTITY_PROVIDER_LIST_HEADERS)
+
+    def test_idp_set(self):
+        identity_provider = self._create_dummy_idp(add_clean_up=True)
+        new_remoteid = data_utils.rand_name('newRemoteId')
+        raw_output = self.openstack('identity provider set '
+                                    '%(identity-provider)s '
+                                    '--remote-id %(remote-id)s '
+                                    % {'identity-provider': identity_provider,
+                                       'remote-id': new_remoteid})
+        self.assertEqual(0, len(raw_output))
+        raw_output = self.openstack('identity provider show %s'
+                                    % identity_provider)
+        updated_value = self.parse_show_as_object(raw_output)
+        self.assertIn(new_remoteid, updated_value['remote_ids'])