openstack/python-openstackclient
Code Issues Proposed changes

Fix errors in volume set/unset image properties unit tests

Browse Source 
These errors may caused by copy-paste, we should specify
a fake return value for get() method but not create() method.
Create() mothod will not called in set/unset command. After
specifing the return value of get(), we can use the fake volume
in the assert.

Change-Id: I1e0df4c28ece373168788c396e9082d565e36cc7
This commit is contained in:
Huanxuan Ao
2016-08-11 11:38:16 +08:00
parent b3248fb0bd
commit 95f0e3dc36
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
openstackclient/tests/volume/v2/test_volume.py
View File

@@ -841,7 +841,7 @@ class TestVolumeSet(TestVolume):
# returns nothing # returns nothing
self.cmd.take_action(parsed_args) self.cmd.take_action(parsed_args)
self.volumes_mock.set_image_metadata.assert_called_with( self.volumes_mock.set_image_metadata.assert_called_with(
self.volumes_mock.get().id, parsed_args.image_property) self.new_volume.id, parsed_args.image_property)
def test_volume_set_state(self): def test_volume_set_state(self):
arglist = [ arglist = [
@@ -919,7 +919,7 @@ class TestVolumeUnset(TestVolume):
super(TestVolumeUnset, self).setUp() super(TestVolumeUnset, self).setUp()
self.new_volume = volume_fakes.FakeVolume.create_one_volume() self.new_volume = volume_fakes.FakeVolume.create_one_volume()
self.volumes_mock.create.return_value = self.new_volume self.volumes_mock.get.return_value = self.new_volume
# Get the command object to set property # Get the command object to set property
self.cmd_set = volume.SetVolume(self.app, None) self.cmd_set = volume.SetVolume(self.app, None)
@@ -963,4 +963,4 @@ class TestVolumeUnset(TestVolume):
self.cmd_unset.take_action(parsed_args_unset) self.cmd_unset.take_action(parsed_args_unset)
self.volumes_mock.delete_image_metadata.assert_called_with( self.volumes_mock.delete_image_metadata.assert_called_with(
self.volumes_mock.get().id, parsed_args_unset.image_property) self.new_volume.id, parsed_args_unset.image_property)