openstack/python-openstackclient
Code Issues Proposed changes

Migrate to flake8.

Browse Source 
Fixes bug 1172444

Change-Id: Ieca721663aea2fd31753df4abfb5b01a7145b26a
This commit is contained in:
Monty Taylor 2013-05-14 08:29:16 -07:00
parent 016a0b301e
commit 967d929207
3 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/shell.py
View File

@ -24,7 +24,7 @@ from cliff import app
from cliff import help from cliff import help
from openstackclient.common import clientmanager from openstackclient.common import clientmanager
from openstackclient.common.commandmanager import CommandManager from openstackclient.common import commandmanager
from openstackclient.common import exceptions as exc from openstackclient.common import exceptions as exc
from openstackclient.common import openstackkeyring from openstackclient.common import openstackkeyring
from openstackclient.common import utils from openstackclient.common import utils
@ -63,7 +63,7 @@ class OpenStackShell(app.App):
super(OpenStackShell, self).__init__( super(OpenStackShell, self).__init__(
description=__doc__.strip(), description=__doc__.strip(),
version=VERSION, version=VERSION,
command_manager=CommandManager('openstack.cli')) command_manager=commandmanager.CommandManager('openstack.cli'))
# This is instantiated in initialize_app() only when using # This is instantiated in initialize_app() only when using
# password flow auth # password flow auth

7
tools/test-requires
View File

@ -1,3 +1,9 @@
# Install bounded pep8/pyflakes first, then let flake8 install
pep8==1.4.5
pyflakes==0.7.2
flake8==2.0
hacking>=0.5.3,<0.6
distribute>=0.6.24 distribute>=0.6.24
coverage coverage
@ -5,7 +11,6 @@ discover
fixtures>=0.3.12 fixtures>=0.3.12
mock mock
openstack.nose_plugin openstack.nose_plugin
pep8==1.3.3
sphinx>=1.1.2 sphinx>=1.1.2
testrepository>=0.0.13 testrepository>=0.0.13
testtools>=0.9.26 testtools>=0.9.26

8
tox.ini
View File

@ -11,8 +11,7 @@ deps = -r{toxinidir}/tools/pip-requires
commands = python setup.py testr --testr-args='{posargs}' commands = python setup.py testr --testr-args='{posargs}'
[testenv:pep8] [testenv:pep8]
deps = pep8==1.3.3 commands = flake8
commands = pep8 --ignore=E126,E202,W602 --repeat --show-source openstackclient setup.py
[testenv:venv] [testenv:venv]
commands = {posargs} commands = {posargs}
@ -22,3 +21,8 @@ commands = python setup.py testr --coverage --testr-args='{posargs}'
[tox:jenkins] [tox:jenkins]
downloadcache = ~/cache/pip downloadcache = ~/cache/pip
[flake8]
ignore = E126,E202,W602,H402
show-source = True
exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools